Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 2497713002: Disable system_health.memory_desktop on Win and Mac perf bots (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.timeline import chrome_trace_category_filter 9 from telemetry.timeline import chrome_trace_category_filter
10 from telemetry.web_perf import timeline_based_measurement 10 from telemetry.web_perf import timeline_based_measurement
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 def Name(cls): 112 def Name(cls):
113 return 'system_health.memory_%s' % cls.PLATFORM 113 return 'system_health.memory_%s' % cls.PLATFORM
114 114
115 @classmethod 115 @classmethod
116 def ValueCanBeAddedPredicate(cls, value, is_first_result): 116 def ValueCanBeAddedPredicate(cls, value, is_first_result):
117 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard 117 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
118 # is able to cope with the data load generated by TBMv2 metrics. 118 # is able to cope with the data load generated by TBMv2 metrics.
119 return not _IGNORED_STATS_RE.search(value.name) 119 return not _IGNORED_STATS_RE.search(value.name)
120 120
121 121
122 @benchmark.Disabled('win') # crbug.com/656040
123 @benchmark.Disabled('mac') # crbug.com/663025
122 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark): 124 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):
123 """Desktop Chrome Memory System Health Benchmark.""" 125 """Desktop Chrome Memory System Health Benchmark."""
124 PLATFORM = 'desktop' 126 PLATFORM = 'desktop'
125 127
126 @classmethod 128 @classmethod
127 def ShouldDisable(cls, possible_browser): 129 def ShouldDisable(cls, possible_browser):
128 # http://crbug.com/624355 (reference builds). 130 # http://crbug.com/624355 (reference builds).
129 return (possible_browser.platform.GetDeviceTypeName() != 'Desktop' or 131 return (possible_browser.platform.GetDeviceTypeName() != 'Desktop' or
130 possible_browser.browser_type == 'reference') 132 possible_browser.browser_type == 'reference')
131 133
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 and load a blank page with multiprocess enabled. 186 and load a blank page with multiprocess enabled.
185 """ 187 """
186 188
187 def SetExtraBrowserOptions(self, options): 189 def SetExtraBrowserOptions(self, options):
188 options.AppendExtraBrowserArgs( 190 options.AppendExtraBrowserArgs(
189 ['--webview-sandboxed-renderer']) 191 ['--webview-sandboxed-renderer'])
190 192
191 @classmethod 193 @classmethod
192 def Name(cls): 194 def Name(cls):
193 return 'system_health.webview_startup_multiprocess' 195 return 'system_health.webview_startup_multiprocess'
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698