W3C test importer: skip ref test if ref file not found.

W3C test importer: skip ref test if ref file not found.

Reason: When auto-importing tests, is there's an issue with one test, in general we want to print an error message and continue trying to import any tests that can be imported.

BUG=664663
Committed: https://crrev.com/b3c467a500e59cb7af25829968118287179ddb86
Cr-Commit-Position: refs/heads/master@{#432576}

[qyearsley, 2016-11-12 00:13:49]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2016-11-12 00:16:23]

Description was changed from

==========
Importer: skip ref test if ref file not found.

BUG=664663
==========

to

==========
W3C test importer: skip ref test if ref file not found.

Reason: When auto-importing tests, is there's an issue with one test, in general
we want to print an error message and continue trying to import any tests that
can be imported.

BUG=664663
==========

[qyearsley, 2016-11-12 00:16:30]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[qyearsley, 2016-11-12 00:16:33]

https://codereview.chromium.org/2497673003/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/2497673003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:270: continue
This part is the actual main change for this CL.

https://codereview.chromium.org/2497673003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:353:
_log.error('%s not found. Possible error in the test.', orig_filepath)
In theory I think we might not hit this condition any more after this change.

https://codereview.chromium.org/2497673003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:383:
host=self.host)
This change makes it so that the MockFileSystem is used in tests for
convert_for_webkit.

https://codereview.chromium.org/2497673003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:395:
self.filesystem.write_text_file(new_filepath, converted_file[1])
This change makes it so that the MockFileSystem is used in tests.

[commit-bot: I haz the power, 2016-11-12 00:17:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 01:32:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 01:32:57]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-11-15 00:23:10]

qyearsley@chromium.org changed reviewers:
+ jsbell@chromium.org

[qyearsley, 2016-11-15 22:13:06]

This CL is ready to review (although it's not urgent).

[jsbell, 2016-11-16 17:25:02]

lgtm

[qyearsley, 2016-11-16 17:44:23]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-11-16 17:44:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 18:56:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-16 19:22:05]

Description was changed from

==========
W3C test importer: skip ref test if ref file not found.

Reason: When auto-importing tests, is there's an issue with one test, in general
we want to print an error message and continue trying to import any tests that
can be imported.

BUG=664663
==========

to

==========
W3C test importer: skip ref test if ref file not found.

Reason: When auto-importing tests, is there's an issue with one test, in general
we want to print an error message and continue trying to import any tests that
can be imported.

BUG=664663

Committed: https://crrev.com/b3c467a500e59cb7af25829968118287179ddb86
Cr-Commit-Position: refs/heads/master@{#432576}
==========

[commit-bot: I haz the power, 2016-11-16 19:22:06]

Patchset 1 (id:??) landed as
https://crrev.com/b3c467a500e59cb7af25829968118287179ddb86
Cr-Commit-Position: refs/heads/master@{#432576}