Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Issue 2497673003: W3C test importer: skip ref test if ref file not found. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
index ca8a2e766ca01256a59cbbf2b10b02d455c399a5..338be36f609f191d6a670a5ccb0bc1d1ea1ab539 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
@@ -136,3 +136,40 @@ class TestImporterTest(unittest.TestCase):
self.assertEqual(
host.filesystem.executable_files,
set(['/mock-checkout/third_party/WebKit/LayoutTests/w3c/blink/w3c/dir/has_shebang.txt']))
+
+ def test_ref_test_with_ref_is_copied(self):
+ host = MockHost()
+ host.filesystem = MockFileSystem(files={
+ '/blink/w3c/dir1/my-ref-test.html': '<html><head><link rel="match" href="ref-file.html" />test</head></html>',
+ '/blink/w3c/dir1/ref-file.html': '<html><head>test</head></html>',
+ '/mock-checkout/third_party/WebKit/LayoutTests/W3CImportExpectations': '',
+ '/mock-checkout/third_party/WebKit/Source/core/css/CSSProperties.in': '',
+ })
+ importer = TestImporter(host, FAKE_SOURCE_REPO_DIR, self.options())
+ importer.find_importable_tests()
+ self.assertEqual(
+ importer.import_list,
+ [
+ {
+ 'copy_list': [
+ {'src': '/blink/w3c/dir1/ref-file.html', 'dest': 'ref-file.html'},
+ {'src': '/blink/w3c/dir1/ref-file.html', 'dest': 'my-ref-test-expected.html', 'reference_support_info': {}},
+ {'src': '/blink/w3c/dir1/my-ref-test.html', 'dest': 'my-ref-test.html'}
+ ],
+ 'dirname': '/blink/w3c/dir1',
+ 'jstests': 0,
+ 'reftests': 1,
+ 'total_tests': 1
+ }
+ ])
+
+ def test_ref_test_without_ref_is_skipped(self):
+ host = MockHost()
+ host.filesystem = MockFileSystem(files={
+ '/blink/w3c/dir1/my-ref-test.html': '<html><head><link rel="match" href="not-here.html" /></head></html>',
+ '/mock-checkout/third_party/WebKit/LayoutTests/W3CImportExpectations': '',
+ '/mock-checkout/third_party/WebKit/Source/core/css/CSSProperties.in': '',
+ })
+ importer = TestImporter(host, FAKE_SOURCE_REPO_DIR, self.options())
+ importer.find_importable_tests()
+ self.assertEqual(importer.import_list, [])
« third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698