Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2497663003: Make silent task retries more obvious (Closed)

Created:
4 years, 1 month ago by kjlubick
Modified:
4 years, 1 month ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Make silent task retries more obvious This adds a task-disambiguation element that shows the (silent) retries, their state and the bot. Since milo-pages are not generated for tasks not ending in 0, I added an explanation for when this happens. This also tweaks the gpu sorting order on the botlist page. I had considered making the task list on the bot-page link to the non-summary version of the task, but I decided the task-disambiguation explains more (i.e. the task was retried). BUG=661152 Committed: https://github.com/luci/luci-py/commit/98d1837347d53ed9a540c94e3878b2625b9b2206

Patch Set 1 #

Patch Set 2 : Task disambiguation mostly works, with a message to user #

Patch Set 3 : Add docs and tidy up #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -34 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 2 4 chunks +63 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 1 chunk +13 lines, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/common/common-behavior.html View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/task-behavior.html View 1 chunk +21 lines, -1 line 0 comments Download
A appengine/swarming/ui/res/imp/taskpage/task-disambiguation.html View 1 2 1 chunk +163 lines, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 10 chunks +32 lines, -21 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page-demo.html View 1 2 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
timc822
4 years, 1 month ago (2016-11-12 04:55:54 UTC) #2
timc822
4 years, 1 month ago (2016-11-12 07:59:31 UTC) #3
kjlubick
Live example: https://2466-e3fbb1f-tainted-kjlubick-dot-chromium-swarm.appspot.com/task?id=32344a51fa476910&refresh=10 https://screenshot.googleplex.com/CvnYhX1CPJj Milo message: https://screenshot.googleplex.com/ZO5QmUCLgqv
4 years, 1 month ago (2016-11-14 16:44:41 UTC) #8
stephana
On 2016/11/14 16:44:41, kjlubick wrote: > Live example: > https://2466-e3fbb1f-tainted-kjlubick-dot-chromium-swarm.appspot.com/task?id=32344a51fa476910&refresh=10 > > https://screenshot.googleplex.com/CvnYhX1CPJj > > ...
4 years, 1 month ago (2016-11-14 18:14:08 UTC) #9
KevinL
lgtm
4 years, 1 month ago (2016-11-14 18:53:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497663003/60001
4 years, 1 month ago (2016-11-14 18:54:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/327d056848165610)
4 years, 1 month ago (2016-11-14 19:00:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497663003/60001
4 years, 1 month ago (2016-11-14 19:43:19 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 19:47:57 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/98d1837347d53ed9a540c94e3878b2625b9b2206

Powered by Google App Engine
This is Rietveld 408576698