Make silent task retries more obvious

appengine/swarming/ui/res/imp/taskpage/task-page.html

 <!--
   Copyright 2016 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 
   This in an HTML Import-able file that contains the definition
   of the following elements:
 
     <task-page>
 
@@ skipping 23 matching lines @@
 
 <link rel="import" href="/res/imp/common/common-behavior.html">
 <link rel="import" href="/res/imp/common/error-toast.html">
 <link rel="import" href="/res/imp/common/interval-timer.html">
 <link rel="import" href="/res/imp/common/single-page-style.html">
 <link rel="import" href="/res/imp/common/swarming-app.html">
 <link rel="import" href="/res/imp/common/task-behavior.html">
 <link rel="import" href="/res/imp/common/url-param.html">
 
 <link rel="import" href="task-page-data.html">
+<link rel="import" href="task-disambiguation.html">
 
 <dom-module id="task-page">
   <template>
     <style include="iron-flex iron-flex-alignment swarming-app-style single-page-style task-style">
       .milo {
         width: calc(100% - 11px);
         /** We don't control the milo site and it's on a different domain than
         us, so there's no good way to avoid scrolling other than tell the iframe
         it is really tall.*/
         height: 2000px;
@@ skipping 29 matching lines @@
       .tabbed {
         border: 3px solid #1F78B4;
         margin-left: 5px;
         min-height: 80vh;
       }
     </style>
 
     <url-param name="id"
       value="{{task_id}}">
     </url-param>
+    <url-param name="try_detail"
+      value="{{_try_detail}}">
+    </url-param>
     <url-param name="request_detail"
       value="{{_request_detail}}">
     </url-param>
     <url-param name="show_raw"
       value="{{_show_raw}}">
     </url-param>
     <url-param name="refresh"
       value="{{_refresh_interval}}"
       default_value="10">
     </url-param>
 
     <swarming-app
       client_id="[[client_id]]"
       auth_headers="{{_auth_headers}}"
       permissions="{{_permissions}}"
       profile="{{_profile}}"
       server_details="{{_server_details}}"
       signed_in="{{_signed_in}}"
 
-      busy="[[_busy]]"
+      busy="[[_or(_busy1,busy2)]]"
       name="Swarming Task Page">
 
       <h2 hidden$="[[_signed_in]]">You must sign in to see anything useful.</h2>
 
       <div hidden$="[[_not(_signed_in)]]">
 
         <task-page-data
           id="data"
           auth_headers="[[_auth_headers]]"
           task_id="[[task_id]]"
 
-          busy="{{_busy}}"
+          busy="{{_busy1}}"
           request="{{_request}}"
           result="{{_result}}"
           stdout="{{_stdout}}"
           task_exists="{{_task_exists}}">
         </task-page-data>
 
         <div class="horizontal layout wrap">
           <div class="left flex">
             <div class="horizontal layout">
               <paper-input class="id_input" label="Task id" value="{{task_id}}"></paper-input>
               <button on-click="_refresh">
                 <iron-icon class="refresh" icon="icons:refresh"></iron-icon>
               </button>
               <button on-click="_promptRetry">Retry</button>
               <template is="dom-if" if="[[_canCancelTask(_result,_permissions)]]">
                 <button on-click="_promptCancel">Cancel</button>
               </template>
             </div>
             <h2 hidden$="[[_task_exists]]">Task not found.</h2>
+
+            <template is="dom-if" if="[[_disambiguate(task_id,_result)]]">
+              <h2>Displaying a summary for a task with multiple tries</h2>
+              <task-disambiguation
+                busy="{{busy2}}"
+                auth_headers="[[_auth_headers]]"
+                task_id="[[task_id]]"
+                summary_result="[[_result]]">
+              </task-disambiguation>
+            </template>
+
             <table hidden$="[[_not(_task_exists)]]">
               <tr>
                 <td>Name</td>
                 <td>[[_request.name]]</td>
               </tr>
               <tr>
                 <td>State</td>
-                <td class$="[[_stateClass(_result)]]">[[_state(_result)]]</td>
+                <td class$="[[_stateClass(_result)]]">[[state(_result)]]</td>
               </tr>
               <tr>
                 <td>Created</td>
                 <td title$="[[_request.created_ts]]">[[_request.human_created_ts]]</td>
               </tr>
               <template is="dom-if" if="[[_wasPickedUp(_result)]]">
                 <tr>
                   <td>Started</td>
                   <td title$="[[_result.started_ts]]">[[_result.human_started_ts]]</td>
                 </tr>
@@ skipping 290 matching lines @@
                 value="{{_refresh_interval}}"
                 title="How often to refresh all information about the task"
                 auto-validate
                 min="1"
                 max="1000"
                 pattern="[0-9]+">
               </paper-input>
             </div>
 
             <template is="dom-if" if="[[_supportsMilo(_request,_show_raw)]]">
+              <div class="milo tabbed" hidden$="[[_isSummaryLink(task_id)]]">
+                Milo results are only generated for task summaires, that is, tasks whose ids end in 0.  Tasks ending in 1 or 2 represent possible retries of tasks.  See <a href="//goo.gl/LE4rwV">the docs</a> for more.
+              </div>
               <iframe id="miloFrame" class="milo tabbed" src$="[[_getDisplayServerLink(_server_details.display_server_url_template,task_id)]]"></iframe>
             </template>
             <template is="dom-if" if="[[_show_raw]]">
               <div class="code stdout tabbed">[[_stdout]]</div>
             </template>
           </div>
         </div>
       </div>
     </swarming-app>
 
@@ skipping 108 matching lines @@
           p.requested = p.package_name + ":" + p.version;
           actual.forEach(function(c) {
             if (c.path === p.path) {
               p.actual = c.package_name + ":" + c.version;
             }
           });
         });
         return packages;
       },
 
+      _disambiguate: function(taskId, result) {
+        if (!taskId.endsWith("0") || !result) {
+          return false;
+        }
+        return result.try_number > 1;
+      },
+
       _expires: function(request) {
         var delta = parseInt(request.expiration_secs);
         if (delta) {
           return sk.human.localeTime(new Date(request.created_ts.getTime() + delta * 1000));
         }
         // Fall back to something
         return request.expiration_secs + " seconds from created time";
       },
 
       _extraArgs: function(request) {
@@ skipping 26 matching lines @@
       },
 
       _isolateLink: function(ref) {
         if (!ref || !ref.isolatedserver) {
           return undefined;
         }
         return ref.isolatedserver + "/browse?namespace="+ref.namespace +
           "&hash=" + ref.isolated;
       },
 
+      _isSummaryLink: function(taskId) {
+        return taskId && taskId.endsWith(0);
+      },
+
       _noMilo: function(result) {
         return !this._tag(result, "allow_milo");
       },
 
       _pending: function(result) {
         if (!result.created_ts) {
           return "";
         }
         var end = result.started_ts || result.abandoned_ts || new Date();
         // In the case of deduplicated tasks, started_ts comes before the task.
@@ skipping 79 matching lines @@
       },
 
       _empty: function(array) {
         return !array || array.length == 0;
       },
 
       _supportsMilo: function(request, showRaw) {
         return !showRaw && request && this._tag(request, "allow_milo");
       },
 
-      _state: function(result) {
-        if (!result) {
-          return "";
-        }
-        if (result.state === this.COMPLETED) {
-          if (result.failure) {
-            return this.COMPLETED_FAILURE;
-          }
-          if (result.try_number === "0") {
-            return this.COMPLETED_DEDUPED;
-          }
-          return this.COMPLETED_SUCCESS;
-        }
-        return result.state;
-      },
 
-      _stateClass: function(result) {
-        return this.stateClass(this._state(result));
-      },
 
       _toggleDetails: function() {
         this.set("_request_detail", !this._request_detail);
       },
 
       _tag: function(result, col) {
         if (!result || !result.tagMap) {
           return undefined;
         }
         return result.tagMap[col];
       },
 
       _wasPickedUp: function(result) {
         return result && result.state !== this.PENDING && result.state !== this.CANCELED && result.state != this.EXPIRED;
       },
 
       _wasNotPickedUp: function(result) {
         return result && !this._wasPickedUp(result);
       },
     });
   })();
   </script>
 </dom-module>