Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: Source/core/loader/HistoryController.cpp

Issue 24976002: HistoryController shouldn't call confusingAndOftenMisusedAttached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/HistoryController.cpp
diff --git a/Source/core/loader/HistoryController.cpp b/Source/core/loader/HistoryController.cpp
index f6d2cec7ca5ac9b565de504e2e11d680d146dfb5..8b2360ec92b4fc89ad5271367decce4b499cc962 100644
--- a/Source/core/loader/HistoryController.cpp
+++ b/Source/core/loader/HistoryController.cpp
@@ -123,7 +123,7 @@ void HistoryController::saveDocumentAndScrollState()
Document* document = m_frame->document();
ASSERT(document);
- if (m_currentItem->isCurrentDocument(document) && document->confusingAndOftenMisusedAttached()) {
+ if (m_currentItem->isCurrentDocument(document) && document->renderer()) {
esprehn 2013/09/27 18:23:45 I usually use renderView() since it's more clear,
abarth-chromium 2013/09/27 18:26:13 Ok. That will require me to pull in another heade
LOG(Loading, "WebCoreLoading %s: saving form state to %p", m_frame->tree()->uniqueName().string().utf8().data(), m_currentItem.get());
m_currentItem->setDocumentState(document->formElementsState());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698