HistoryController shouldn't call confusingAndOftenMisusedAttached

Source/core/loader/HistoryController.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 105 matching lines @@
 }
 
 void HistoryController::saveDocumentAndScrollState()
 {
     if (!m_currentItem)
         return;
 
     Document* document = m_frame->document();
     ASSERT(document);
 
-    if (m_currentItem->isCurrentDocument(document) && document->confusingAndOftenMisusedAttached()) {
+    if (m_currentItem->isCurrentDocument(document) && document->renderer()) {

[esprehn, 2013/09/27 18:23:45]

I usually use renderView() since it's more clear, we should probably make
Document::renderer private.

[abarth-chromium, 2013/09/27 18:26:13]

Ok.  That will require me to pull in another header (because it's defined in
RenderView.h), but that's fine.

         LOG(Loading, "WebCoreLoading %s: saving form state to %p", m_frame->tree()->uniqueName().string().utf8().data(), m_currentItem.get());
         m_currentItem->setDocumentState(document->formElementsState());
     }
 
     if (!m_frame->view())
         return;
 
     m_currentItem->setScrollPoint(m_frame->view()->scrollPosition());
 
     Page* page = m_frame->page();
@@ skipping 446 matching lines @@
         m_currentItem->setURLString(urlString);
     m_currentItem->setTitle(title);
     m_currentItem->setStateObject(stateObject);
     m_currentItem->setFormData(0);
     m_currentItem->setFormContentType(String());
 
     ASSERT(m_frame->page());
 }
 
 } // namespace WebCore