Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2497533003: [sync] Reland of "TwoClientBookmarksSyncTest.Sanity" is flaky (Closed)

Created:
4 years, 1 month ago by Patrick Noland
Modified:
4 years ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] Reland of "TwoClientBookmarksSyncTest.Sanity" is flaky Fix race condition in TwoClientUssSyncTest.ConflictResolution that was exposed by the speedup BUG=660655 R=zea@chromium.org Committed: https://crrev.com/dcdd97e380a2f5125c55774f486eab1569625edd Cr-Commit-Position: refs/heads/master@{#431944}

Patch Set 1 : Original patch #

Patch Set 2 : Fix TwoClientUssSyncTest.ConflictResolution #

Messages

Total messages: 16 (11 generated)
Patrick Noland
Nicolas, PTAL
4 years, 1 month ago (2016-11-11 23:46:27 UTC) #3
Nicolas Zea
LGTM FYI if you're relanding a patch with modifications, it's useful to have the first ...
4 years, 1 month ago (2016-11-12 00:07:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497533003/60001
4 years, 1 month ago (2016-11-14 17:59:13 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/dcdd97e380a2f5125c55774f486eab1569625edd Cr-Commit-Position: refs/heads/master@{#431944}
4 years, 1 month ago (2016-11-14 23:12:47 UTC) #15
stgao
4 years ago (2016-11-21 19:47:45 UTC) #16
Message was sent while issue was closed.
FYI: this CL seems to make TwoClientSessionsSyncTest.DeleteIdleSession flaky as
show in
https://findit-for-me.appspot.com/waterfall/check-flake?master_name=chromium....

One occurrence on Waterfall is
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/32055

Powered by Google App Engine
This is Rietveld 408576698