Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6328)

Unified Diff: chrome/browser/sync/test/integration/two_client_uss_sync_test.cc

Issue 2497533003: [sync] Reland of "TwoClientBookmarksSyncTest.Sanity" is flaky (Closed)
Patch Set: Fix TwoClientUssSyncTest.ConflictResolution Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc b/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
index c1a597d01587ba3402366ebfcbbe4a96d806e053..8a6f76c07573cb945ee6fe683cb90f1595bf8e12 100644
--- a/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
@@ -303,6 +303,9 @@ IN_PROC_BROWSER_TEST_F(TwoClientUssSyncTest, ConflictResolution) {
// Write conflicting entities.
model0->WriteItem(kKey1, kValue1);
+ // Wait for the server to see the first commit to avoid a race condition where
+ // both clients commit without seeing each other's update.
+ ASSERT_TRUE(ServerCountMatchStatusChecker(syncer::PREFERENCES, 1).Wait());
model1->WriteItem(kKey1, kValue2);
// Wait for them to be resolved to kResolutionValue by the custom conflict

Powered by Google App Engine
This is Rietveld 408576698