Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2497503004: Revert of Refactor context creation parameters into a struct. (Closed)

Created:
4 years, 1 month ago by Alexander Alekseev
Modified:
4 years, 1 month ago
CC:
android-webview-reviews_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, kalyank, mac-reviews_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor context creation parameters into a struct. (patchset #2 id:20001 of https://codereview.chromium.org/2480373002/ ) Reason for revert: Speculative revert because of https://crbug.com/664719 Original issue's description: > Refactor context creation parameters into a struct. > > This allows for easily adding new parameters to GL context creation, added > parameters for creating contexts with > EGL_CHROMIUM_create_context_bind_generates_resource and > EGL_ANGLE_create_context_webgl_compatibility. > > Small related fix: disallow create-on-bind for vertex arrays and transform > feedbacks in the passthrough command buffer, these objects do not allow > create-on-bind by the ES 3.0 spec but the semantics were mistakenly added. > > BUG=angleproject:1518 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/df7fff2d416e731d3a968cf6bd16bb6f5f60eaee > Cr-Commit-Position: refs/heads/master@{#431412} TBR=dalecurtis@chromium.org,kylechar@chromium.org,piman@chromium.org,posciak@chromium.org,rjkroege@chromium.org,torne@chromium.org,thomasanderson@google.com,geofflang@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=angleproject:1518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -291 lines) Patch
M android_webview/browser/scoped_app_gl_state_restore.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/test/fake_window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gl_context_virtual_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 5 chunks +35 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 2 chunks +4 lines, -13 lines 0 comments Download
D gpu/command_buffer/service/service_utils.h View 1 chunk +0 lines, -24 lines 0 comments Download
D gpu/command_buffer/service/service_utils.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/context.cc View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.cc View 4 chunks +6 lines, -13 lines 0 comments Download
M gpu/perftests/texture_upload_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/android_video_decode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/rendering_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context.h View 3 chunks +3 lines, -9 lines 0 comments Download
M ui/gl/gl_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_context_cgl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_cgl.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M ui/gl/gl_context_egl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_egl.cc View 4 chunks +20 lines, -41 lines 0 comments Download
M ui/gl/gl_context_glx.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_glx.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M ui/gl/gl_context_osmesa.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_osmesa.cc View 1 chunk +1 line, -6 lines 0 comments Download
M ui/gl/gl_context_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_stub.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_context_wgl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_wgl.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 5 chunks +1 line, -17 lines 0 comments Download
M ui/gl/init/gl_factory.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/gl/init/gl_factory_android.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/gl/init/gl_factory_mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/init/gl_factory_ozone.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gl/init/gl_factory_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gl/init/gl_factory_x11.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gl/test/gl_image_test_template.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/common/gl_ozone_egl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/common/gl_ozone_egl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/x11/gl_ozone_glx.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/x11/gl_ozone_glx.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/public/gl_ozone.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Alexander Alekseev
Created Revert of Refactor context creation parameters into a struct.
4 years, 1 month ago (2016-11-12 08:37:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497503004/1
4 years, 1 month ago (2016-11-12 08:37:14 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 08:40:04 UTC) #5
Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698