Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2497463004: Loading: move core/fetch/*Resource* to core/loader/resource/ (Closed)

Created:
4 years, 1 month ago by Takashi Toyoshima
Modified:
4 years, 1 month ago
CC:
chromium-reviews, eae+blinkwatch, fs, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, caseq+blink_chromium.org, krit, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, gyuyoung2, falken+watch_chromium.org, pdr+svgwatchlist_chromium.org, blink-worker-reviews_chromium.org, blink-reviews-style_chromium.org, sof, Yoav Weiss, lushnikov+blink_chromium.org, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, loading-reviews+parser_chromium.org, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, f(malita), horo+watch_chromium.org, Stephen Chennney, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: move core/fetch/*Resource* to core/loader/resource/ To remove core/ dependency so that core/fetch can be moved under platform, move Resource and ResourceClient classes and inheritances to core/loader/resource/. This change is the first step, moving classes on that classes under core/fetch/ do not depend. BUG=655920 Committed: https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8 Cr-Commit-Position: refs/heads/master@{#432431}

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : [rebase] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -886 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunnerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/BUILD.gn View 4 chunks +1 line, -8 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/DocumentResource.h View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/DocumentResource.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/LinkFetchResource.h View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/LinkFetchResource.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ScriptResource.h View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.h View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/BUILD.gn View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h View 1 chunk +0 lines, -211 lines 0 comments Download
D third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/DocumentResource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/DocumentResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/LinkFetchResource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/LinkFetchResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/LinkPreloadResourceClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/ScriptResource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/XSLStyleSheetResource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/resource/XSLStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElementProxy.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGResourceClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkletScriptLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLImportRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (13 generated)
Takashi Toyoshima
This is the first change that contains mechanical parts to move Resource/ResourceClient sub-classes to loader/resource. ...
4 years, 1 month ago (2016-11-11 06:29:51 UTC) #5
yhirano
lgtm
4 years, 1 month ago (2016-11-15 03:37:56 UTC) #8
hiroshige
lgtm
4 years, 1 month ago (2016-11-15 09:59:34 UTC) #9
kouhei (in TOK)
lgtm
4 years, 1 month ago (2016-11-15 16:37:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497463004/40001
4 years, 1 month ago (2016-11-16 04:48:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/315751)
4 years, 1 month ago (2016-11-16 05:41:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497463004/40001
4 years, 1 month ago (2016-11-16 06:48:29 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 08:36:48 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 08:41:36 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cfac0465b75d41170c765d1d1d3463917e7f79f8
Cr-Commit-Position: refs/heads/master@{#432431}

Powered by Google App Engine
This is Rietveld 408576698