Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2497463002: Fix Vietnamese characters to work correctly on contenteditable (Closed)

Created:
4 years, 1 month ago by Changwan Ryu
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix Vietnamese characters to work correctly on contenteditable Blink seems to convert a normal space (\20) into a non-breaking space (\a0) only when Vietnamese + contenteditable is used. The immediate solution for M55 is to copy the same replacing logic from ReplicaInputConnection to ThreadedInputConnection. FYI, the ReplicaInputConnection logic was there from the beginning: https://chromiumcodereview.appspot.com/10911012/diff/10001/content/ public/android/java/src/org/chromium/content/browser/ContentViewCore.java BUG=663880 Review-Url: https://codereview.chromium.org/2489233004 Cr-Commit-Position: refs/heads/master@{#431363} (cherry picked from commit a90b47231f92d86db194138b952ad0910ee923eb) Committed: https://chromium.googlesource.com/chromium/src/+/d744333cb7410f973555d755778b3fa85a2c1c52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Changwan Ryu
4 years, 1 month ago (2016-11-10 23:11:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d744333cb7410f973555d755778b3fa85a2c1c52.

Powered by Google App Engine
This is Rietveld 408576698