Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2489233004: Fix Vietnamese characters to work correctly on contenteditable (Closed)

Created:
4 years, 1 month ago by Changwan Ryu
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Vietnamese characters to work correctly on contenteditable Blink seems to convert a normal space (\20) into a non-breaking space (\a0) only when Vietnamese + contenteditable is used. The immediate solution for M55 is to copy the same replacing logic from ReplicaInputConnection to ThreadedInputConnection. FYI, the ReplicaInputConnection logic was there from the beginning: https://chromiumcodereview.appspot.com/10911012/diff/10001/content/ public/android/java/src/org/chromium/content/browser/ContentViewCore.java BUG=663880 Committed: https://crrev.com/a90b47231f92d86db194138b952ad0910ee923eb Cr-Commit-Position: refs/heads/master@{#431363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Changwan Ryu
4 years, 1 month ago (2016-11-10 19:52:13 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-10 20:38:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489233004/1
4 years, 1 month ago (2016-11-10 21:31:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 21:39:24 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 22:34:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a90b47231f92d86db194138b952ad0910ee923eb
Cr-Commit-Position: refs/heads/master@{#431363}

Powered by Google App Engine
This is Rietveld 408576698