Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2497343002: Updating foreign tabs suggestion's title and text. (Closed)

Created:
4 years, 1 month ago by skym
Modified:
4 years, 1 month ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating foreign tabs suggestion's title and text. Two separate things are being changes in this: * The title of the foreign tabs suggestions on the new tab page is being updated from "Continue from another device" to "Recent tabs". This helps bring the title more inline with existing UI, and is shorter. There are not currently any local tab suggestions on this page so we dodge ambiguity for now. This could change in the future. * The individual suggestions no longer contain the foreign device's name. The name is sometimes not very readable or useful, and created long, ugly lines. This also results in a very consistent experience between this section and the other sections, where the 'publisher' line only contains favicon, domain, and age. BUG=663966 Committed: https://crrev.com/737a80cd1ba84e6c60347b0950f679bcb6eef57f Cr-Commit-Position: refs/heads/master@{#432199}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc View 1 chunk +1 line, -7 lines 0 comments Download
M components/ntp_snippets_strings.grdp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 15 (10 generated)
skym
PTAL
4 years, 1 month ago (2016-11-14 19:50:58 UTC) #8
Marc Treib
lgtm https://codereview.chromium.org/2497343002/diff/1/components/ntp_snippets_strings.grdp File components/ntp_snippets_strings.grdp (right): https://codereview.chromium.org/2497343002/diff/1/components/ntp_snippets_strings.grdp#newcode37 components/ntp_snippets_strings.grdp:37: Recent tabs Currently, this is the same as ...
4 years, 1 month ago (2016-11-15 09:48:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497343002/1
4 years, 1 month ago (2016-11-15 16:55:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 17:01:00 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 17:31:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/737a80cd1ba84e6c60347b0950f679bcb6eef57f
Cr-Commit-Position: refs/heads/master@{#432199}

Powered by Google App Engine
This is Rietveld 408576698