Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

Issue 2497343002: Updating foreign tabs suggestion's title and text. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets_strings.grdp » ('j') | components/ntp_snippets_strings.grdp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
diff --git a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
index 5bd5fa9f606247be8898e76800bc0cc0b44ae45d..79c4b85c8cd8a3e150dee87efb60c004bc0c1194 100644
--- a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
+++ b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
@@ -320,14 +320,8 @@ ContentSuggestion ForeignSessionsSuggestionsProvider::BuildSuggestion(
data.navigation->virtual_url());
suggestion.set_title(data.navigation->title());
suggestion.set_publish_date(data.tab->timestamp);
- // TODO(skym): It's unclear if this simple approach is sufficient for
- // right-to-left languages.
- // This field is sandwiched between the url's favicon, which is on the left,
- // and the |publish_date|, which is to the right. The domain should always
- // appear next to the favicon.
suggestion.set_publisher_name(
- base::UTF8ToUTF16(data.navigation->virtual_url().host() + " - " +
- data.session->session_name));
+ base::UTF8ToUTF16(data.navigation->virtual_url().host()));
return suggestion;
}
« no previous file with comments | « no previous file | components/ntp_snippets_strings.grdp » ('j') | components/ntp_snippets_strings.grdp » ('J')

Powered by Google App Engine
This is Rietveld 408576698