Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: services/ui/ws/window_tree_host_factory.cc

Issue 2497303002: Fix ws::Display initialization order. (Closed)
Patch Set: Fix use after move in test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/ws/user_display_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/window_tree_host_factory.cc
diff --git a/services/ui/ws/window_tree_host_factory.cc b/services/ui/ws/window_tree_host_factory.cc
index bb650a456d4018005846e30b3423807bcfe1536b..1a2170b0a67144aeeaf31f6260afcce47ada1e00 100644
--- a/services/ui/ws/window_tree_host_factory.cc
+++ b/services/ui/ws/window_tree_host_factory.cc
@@ -30,11 +30,11 @@ void WindowTreeHostFactory::AddBinding(
void WindowTreeHostFactory::CreateWindowTreeHost(
mojom::WindowTreeHostRequest host,
mojom::WindowTreeClientPtr tree_client) {
- Display* display = new Display(window_server_, platform_display_init_params_);
+ Display* display = new Display(window_server_);
std::unique_ptr<DisplayBindingImpl> display_binding(
new DisplayBindingImpl(std::move(host), display, user_id_,
std::move(tree_client), window_server_));
- display->Init(std::move(display_binding));
+ display->Init(platform_display_init_params_, std::move(display_binding));
}
} // namespace ws
« no previous file with comments | « services/ui/ws/user_display_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698