services/ui/ws/user_display_manager_unittest.cc - Issue 2497303002: Fix ws::Display initialization order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/ws/user_display_manager_unittest.cc

Issue 2497303002: Fix ws::Display initialization order. (Closed)

Patch Set: Fix use after move in test. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/ws/user_display_manager_unittest.cc

diff --git a/services/ui/ws/user_display_manager_unittest.cc b/services/ui/ws/user_display_manager_unittest.cc

index ee827f0cf209e2818469b46ff184d4df4c36ef53..1380e9f9bdee720e216bc06dcb63a41d99fccb8f 100644

--- a/services/ui/ws/user_display_manager_unittest.cc

+++ b/services/ui/ws/user_display_manager_unittest.cc

@@ -200,8 +200,8 @@ TEST_F(UserDisplayManagerTest, AddRemoveDisplay) {

display_manager_observer1.GetAndClearObserverCalls());

// Add another display.

- Display* display2 = new Display(window_server(), PlatformDisplayInitParams());

- display2->Init(nullptr);

+ Display* display2 = new Display(window_server());

+ display2->Init(PlatformDisplayInitParams(), nullptr);

// Observer should be notified immediately as frame decorations were set.

EXPECT_EQ("OnDisplaysChanged 2",

« no previous file with comments | « services/ui/ws/test_utils.cc ('k') | services/ui/ws/window_tree_host_factory.cc » ('j') | no next file with comments »