Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2497083002: Server push cancellation: clean up the code to make sure shared code is in sync with internal code. (Closed)

Created:
4 years, 1 month ago by Zhongyi Shi
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Server push cancellation: clean up the code to make sure shared code is in sync with internal code. Merge internal change: 138927579. BUG=232040 Committed: https://crrev.com/1cbc95beeba6502738dbe017f48c31316a2aa4ce Cr-Commit-Position: refs/heads/master@{#431731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -72 lines) Patch
M net/net.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_client_promised_info.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_client_promised_info_test.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M net/quic/core/quic_client_session_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +19 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +16 lines, -0 lines 0 comments Download
D net/tools/quic/test_tools/push_promise_delegate.h View 1 chunk +0 lines, -35 lines 0 comments Download
D net/tools/quic/test_tools/push_promise_delegate.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Zhongyi Shi
4 years, 1 month ago (2016-11-12 00:28:24 UTC) #2
Ryan Hamilton
lgtm
4 years, 1 month ago (2016-11-12 00:52:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497083002/1
4 years, 1 month ago (2016-11-12 00:53:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-12 01:43:16 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 01:45:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cbc95beeba6502738dbe017f48c31316a2aa4ce
Cr-Commit-Position: refs/heads/master@{#431731}

Powered by Google App Engine
This is Rietveld 408576698