net/quic/chromium/quic_chromium_client_session_test.cc - Issue 2497083002: Server push cancellation: clean up the code to make sure shared code is in sync with internal code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/quic_chromium_client_session_test.cc

Issue 2497083002: Server push cancellation: clean up the code to make sure shared code is in sync with internal code. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/quic_chromium_client_session_test.cc

diff --git a/net/quic/chromium/quic_chromium_client_session_test.cc b/net/quic/chromium/quic_chromium_client_session_test.cc

index 90f0f2d397d93e8c14b2fb4f1e3968888ad5acd7..b0f1ad329ed635af57b0e04b9194916e856b0c32 100644

--- a/net/quic/chromium/quic_chromium_client_session_test.cc

+++ b/net/quic/chromium/quic_chromium_client_session_test.cc

@@ -44,7 +44,6 @@

#include "net/test/cert_test_util.h"

#include "net/test/gtest_util.h"

#include "net/test/test_data_directory.h"

-#include "net/tools/quic/test_tools/push_promise_delegate.h"

#include "net/udp/datagram_client_socket.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -355,7 +354,7 @@ TEST_P(QuicChromiumClientSessionTest, CancelPushWhenPendingValidation) {

// Initiate rendezvous.

SpdyHeaderBlock client_request = promise_headers.Clone();

- PushPromiseDelegate delegate(/*match=*/true);

+ TestPushPromiseDelegate delegate(/*match=*/true);

promised->HandleClientRequest(client_request, &delegate);

// Cancel the push before receiving the response to the pushed request.

« no previous file with comments | « net/net.gypi ('k') | net/quic/core/quic_client_promised_info.cc » ('j') | no next file with comments »