Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2497053002: [Offline pages] Fixing offline pin icon in omnibox (Closed)

Created:
4 years, 1 month ago by fgorski
Modified:
4 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Fixing offline pin icon in omnibox * Forks offline_pin icon between notification and omnibox, as recent change in the former broke the latter. (Should have been 2 different icons from the start). * Proper M56 solution will unify offline_pin_black and offline_ping_round, but that cannot happen now, because of M55 merge. Will happen next week. BUG=664546 R=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2499713002 Cr-Commit-Position: refs/heads/master@{#431668} (cherry picked from commit e76cac83934a90727118b072d52207b2f1e5fb5c) Committed: https://chromium.googlesource.com/chromium/src/+/9c74eb467d649f74c69c02bc99e875753f0a0a27

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
fgorski
4 years, 1 month ago (2016-11-11 23:30:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c74eb467d649f74c69c02bc99e875753f0a0a27.

Powered by Google App Engine
This is Rietveld 408576698