Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2499713002: [Offline pages] Fixing offline pin icon in omnibox (Closed)

Created:
4 years, 1 month ago by fgorski
Modified:
4 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Fixing offline pin icon in omnibox * Forks offline_pin icon between notification and omnibox, as recent change in the former broke the latter. (Should have been 2 different icons from the start). * Proper M56 solution will unify offline_pin_black and offline_ping_round, but that cannot happen now, because of M55 merge. Will happen next week. BUG=664546 R=tedchoc@chromium.org Committed: https://crrev.com/e76cac83934a90727118b072d52207b2f1e5fb5c Cr-Commit-Position: refs/heads/master@{#431668}

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
fgorski
PTAL. Attempt 2
4 years, 1 month ago (2016-11-11 21:12:54 UTC) #5
Ted C
lgtm
4 years, 1 month ago (2016-11-11 21:14:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499713002/1
4 years, 1 month ago (2016-11-11 21:18:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 22:26:35 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 22:44:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e76cac83934a90727118b072d52207b2f1e5fb5c
Cr-Commit-Position: refs/heads/master@{#431668}

Powered by Google App Engine
This is Rietveld 408576698