Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2497033002: Break apart WebGestureEvent from WebInputEvent. (Closed)

Created:
4 years, 1 month ago by dtapuska
Modified:
4 years, 1 month ago
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, anandc+watch-blimp_chromium.org, asvitkine+watch_chromium.org, bgoldman+watch-blimp_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blundell+watchlist_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, csharrison+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dcheng, devtools-reviews_chromium.org, dglazkov+blink, droger+watchlist_chromium.org, dtapuska+chromiumwatch_chromium.org, dtrainor+watch-blimp_chromium.org, einbinder+watch-test-runner_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, gcasto+watchlist_chromium.org, gcasto+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, jochen+watch_chromium.org, kalyank, khushalsagar+watch-blimp_chromium.org, kinuko+watch, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, loading-reviews+metrics_chromium.org, mac-reviews_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mathp+autofillwatch_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, nyquist+watch-blimp_chromium.org, oshima+watch_chromium.org, perumaal+watch-blimp_chromium.org, pfeldman, piman+watch_chromium.org, rouslan+autofill_chromium.org, scf+watch-blimp_chromium.org, scheib+watch_chromium.org, sdefresne+watchlist_chromium.org, sebsg+autofillwatch_chromium.org, shaktisahu+watch-blimp_chromium.org, shuchen+watch_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, James Su, tdresser+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Break apart WebGestureEvent from WebInputEvent. New methods need to be added to WebGestureEvent and it makes no sense to keep expanding the really large WebInputEvent. Since I'm adjusting a number of the include locations get rid of web/WebInputEvent.h as well; largely done via sed. No behavioural changes intended. BUG=625684 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=rockot@chromium.org, sadrul@chromium.org, wez@chromium.org, dcheng@chromium.org, girard@chromium.org, jochen@chromium.org, creis@chromium.org Committed: https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35 Cr-Commit-Position: refs/heads/master@{#432021}

Patch Set 1 #

Patch Set 2 : Fix android, mac build #

Patch Set 3 : Fix vr shell #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -344 lines) Patch
M blimp/client/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/client/core/input/blimp_input_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/client/core/render_widget/mock_render_widget_feature.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/render_widget/mock_render_widget_feature.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M blimp/engine/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/engine/browser_tests/input_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/engine/feature/engine_render_widget_feature.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/feature/engine_render_widget_feature_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/net/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/net/input_message_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/net/input_message_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/net/input_message_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_controller.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_input_manager.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/first_run/first_run_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/metrics_web_contents_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/flash_permission_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/page_click_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/guest_view/browser/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M components/guest_view/browser/guest_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/event_sender.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/text_input_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/overscroll_controller_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/color_picker.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_ack_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/main_thread_event_queue_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/motion_event_web.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/non_blocking_event_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_pointer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_pointer_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_smooth_move_gesture.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_tap_gesture.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_action_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_action_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_action_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touchpad_tap_suppression_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_android.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_mac.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/overscroll_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/android/sync_compositor_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_param_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_param_traits_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/event_with_latency_info.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/input/event_with_latency_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/gesture_event_stream_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event_ack.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event_stream_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_param_traits_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/input/synthetic_web_input_event_builders.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/input/touch_event_stream_validator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/web_touch_event_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/native_web_keyboard_event.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_widget_host.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/render_widget_host_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/input_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/render_widget_input_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mouse_lock_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/compositor_mus_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/event_conversion.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/event_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/app_window/app_web_contents_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageWidgetDelegate.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageWidgetDelegate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputEvent.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/TouchActionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
A third_party/WebKit/public/platform/WebGestureEvent.h View 1 chunk +171 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 3 chunks +0 lines, -155 lines 0 comments Download
M third_party/WebKit/public/web/WebActiveWheelFlingParameters.h View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/web/WebInputEvent.h View 1 chunk +0 lines, -33 lines 0 comments Download
M ui/content_accelerators/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/content_accelerators/accelerator_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/blink_event_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_scroll_elasticity_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/web_input_event.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/web_input_event_traits.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/web_dialogs/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M ui/web_dialogs/web_dialog_web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (23 generated)
dtapuska
esprehn@ this is almost much of a massive sed. Look at platform/WebGestureEvent.h and platform/WebInputEvent.h for ...
4 years, 1 month ago (2016-11-14 21:22:57 UTC) #19
dtapuska
esprehn@ this is almost much of a massive sed. Look at platform/WebGestureEvent.h and platform/WebInputEvent.h for ...
4 years, 1 month ago (2016-11-14 21:23:02 UTC) #20
esprehn
lgtm, we would normally remove the proxy header separate from the adding of new files ...
4 years, 1 month ago (2016-11-14 22:21:46 UTC) #21
dtapuska
4 years, 1 month ago (2016-11-14 22:36:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497033002/60001
4 years, 1 month ago (2016-11-14 22:41:07 UTC) #26
dcheng
ipc lgtm, though in the future, please explicitly mention that you are TBRing reviewers and ...
4 years, 1 month ago (2016-11-14 22:44:17 UTC) #27
dtapuska
On 2016/11/14 22:44:17, dcheng wrote: > ipc lgtm, though in the future, please explicitly mention ...
4 years, 1 month ago (2016-11-14 22:52:13 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-15 00:38:43 UTC) #30
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:45:00 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35
Cr-Commit-Position: refs/heads/master@{#432021}

Powered by Google App Engine
This is Rietveld 408576698