Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/public/platform/WebInputEvent.h

Issue 2497033002: Break apart WebGestureEvent from WebInputEvent. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebInputEvent.h
diff --git a/third_party/WebKit/public/platform/WebInputEvent.h b/third_party/WebKit/public/platform/WebInputEvent.h
index d0d50a1897e051e3e55f3cce9f71a34508da9b8b..2133aaea5b8fd2487290e608eb4a316a31d67035 100644
--- a/third_party/WebKit/public/platform/WebInputEvent.h
+++ b/third_party/WebKit/public/platform/WebInputEvent.h
@@ -32,7 +32,6 @@
#define WebInputEvent_h
#include "WebCommon.h"
-#include "WebGestureDevice.h"
#include "WebPointerProperties.h"
#include "WebRect.h"
#include "WebTouchPoint.h"
@@ -333,8 +332,6 @@ class WebKeyboardEvent : public WebInputEvent {
nativeKeyCode(0),
isSystemKey(false),
isBrowserShortcut(false) {
- memset(&text, 0, sizeof(text));
- memset(&unmodifiedText, 0, sizeof(unmodifiedText));
}
// Please refer to bug http://b/issue?id=961192, which talks about Webkit
@@ -460,158 +457,6 @@ class WebMouseWheelEvent : public WebMouseEvent {
dispatchType(Blocking) {}
};
-// WebGestureEvent ---------------------------------------------------------
-
-class WebGestureEvent : public WebInputEvent {
- public:
- enum ScrollUnits {
- PrecisePixels = 0, // generated by high precision devices.
- Pixels, // large pixel jump duration; should animate to delta.
- Page // page (visible viewport) based scrolling.
- };
-
- enum InertialPhaseState {
- UnknownMomentumPhase = 0, // No phase information.
- NonMomentumPhase, // Regular scrolling phase.
- MomentumPhase, // Momentum phase.
- };
-
- int x;
- int y;
- int globalX;
- int globalY;
- WebGestureDevice sourceDevice;
-
- // If the WebGestureEvent has sourceDevice=WebGestureDeviceTouchscreen, this
- // field contains the unique identifier for the touch event that released
- // this event at TouchDispositionGestureFilter. If the WebGestureEvents was
- // not released through a touch event (e.g. timer-released gesture events or
- // gesture events with sourceDevice!=WebGestureDeviceTouchscreen), the field
- // contains 0. See crbug.com/618738.
- uint32_t uniqueTouchEventId;
-
- // This field exists to allow BrowserPlugin to mark GestureScroll events as
- // 'resent' to handle the case where an event is not consumed when first
- // encountered; it should be handled differently by the plugin when it is
- // sent for thesecond time. No code within Blink touches this, other than to
- // plumb it through event conversions.
- int resendingPluginId;
-
- union {
- // Tap information must be set for GestureTap, GestureTapUnconfirmed,
- // and GestureDoubleTap events.
- struct {
- int tapCount;
- float width;
- float height;
- } tap;
-
- struct {
- float width;
- float height;
- } tapDown;
-
- struct {
- float width;
- float height;
- } showPress;
-
- struct {
- float width;
- float height;
- } longPress;
-
- struct {
- float firstFingerWidth;
- float firstFingerHeight;
- } twoFingerTap;
-
- struct {
- // Initial motion that triggered the scroll.
- // May be redundant with deltaX/deltaY in the first scrollUpdate.
- float deltaXHint;
- float deltaYHint;
- // Default initialized to ScrollUnits::PrecisePixels.
- ScrollUnits deltaHintUnits;
- // If true, this event will skip hit testing to find a scroll
- // target and instead just scroll the viewport.
- bool targetViewport;
- // The state of inertial phase scrolling. OSX has unique phases for normal
- // and momentum scroll events. Should always be UnknownMomentumPhase for
- // touch based input as it generates GestureFlingStart instead.
- InertialPhaseState inertialPhase;
- // True if this event was synthesized in order to force a hit test;
- // avoiding scroll latching behavior until crbug.com/526463 is fully
- // implemented.
- bool synthetic;
-
- // number of pointers down.
- int pointerCount;
- } scrollBegin;
-
- struct {
- float deltaX;
- float deltaY;
- float velocityX;
- float velocityY;
- // Whether any previous GestureScrollUpdate in the current scroll
- // sequence was suppressed (e.g., the causal touchmove was
- // preventDefault'ed). This bit is particularly useful for
- // determining whether the observed scroll update sequence captures
- // the entirety of the generative motion.
- bool previousUpdateInSequencePrevented;
- bool preventPropagation;
- InertialPhaseState inertialPhase;
- // Default initialized to ScrollUnits::PrecisePixels.
- ScrollUnits deltaUnits;
- } scrollUpdate;
-
- struct {
- // The original delta units the scrollBegin and scrollUpdates
- // were sent as.
- ScrollUnits deltaUnits;
- // The state of inertial phase scrolling. OSX has unique phases for normal
- // and momentum scroll events. Should always be UnknownMomentumPhase for
- // touch based input as it generates GestureFlingStart instead.
- InertialPhaseState inertialPhase;
- // True if this event was synthesized in order to generate the proper
- // GSB/GSU/GSE matching sequences. This is a temporary so that a future
- // GSB will generate a hit test so latching behavior is avoided
- // until crbug.com/526463 is fully implemented.
- bool synthetic;
- } scrollEnd;
-
- struct {
- float velocityX;
- float velocityY;
- // If true, this event will skip hit testing to find a scroll
- // target and instead just scroll the viewport.
- bool targetViewport;
- } flingStart;
-
- struct {
- // If set to true, don't treat flingCancel
- // as a part of fling boost events sequence.
- bool preventBoosting;
- } flingCancel;
-
- struct {
- bool zoomDisabled;
- float scale;
- } pinchUpdate;
- } data;
-
- WebGestureEvent()
- : WebInputEvent(sizeof(WebGestureEvent)),
- x(0),
- y(0),
- globalX(0),
- globalY(0),
- sourceDevice(WebGestureDeviceUninitialized),
- resendingPluginId(-1) {
- memset(&data, 0, sizeof(data));
- }
-};
// WebTouchEvent --------------------------------------------------------------
« no previous file with comments | « third_party/WebKit/public/platform/WebGestureEvent.h ('k') | third_party/WebKit/public/web/WebActiveWheelFlingParameters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698