Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2497013002: Fix a bug in compressed texture code path. (Closed)

Created:
4 years, 1 month ago by Zhenyao Mo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in compressed texture code path. If we specify a texture using texStorage, the texture is uninitialized, so if we call compressedTexSubImage, we need to consider the situation. BUG=663960 TEST=webgl2_conformance (in https://github.com/KhronosGroup/WebGL/pull/2142) R=piman@chromium.org,kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/5219f45e8e6755153240985d4adeae6d27d69db7 Cr-Commit-Position: refs/heads/master@{#431642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +18 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Zhenyao Mo
PTAL. Without this CL, https://github.com/KhronosGroup/WebGL/pull/2142 tests fail. With this CL, the tests pass.
4 years, 1 month ago (2016-11-11 19:32:25 UTC) #3
Ken Russell (switch to Gerrit)
LGTM Thanks for upgrading the conformance tests and sorry I missed testing this code path ...
4 years, 1 month ago (2016-11-11 20:58:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497013002/1
4 years, 1 month ago (2016-11-11 20:58:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 21:03:47 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:09:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5219f45e8e6755153240985d4adeae6d27d69db7
Cr-Commit-Position: refs/heads/master@{#431642}

Powered by Google App Engine
This is Rietveld 408576698