Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2496983003: Use native implementation of dangerous download infobar (Closed)

Created:
4 years, 1 month ago by qinmin
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Use native implementation of dangerous download infobar Currently the dangerous download infobar is implemented in java. This is because some of the download is intercepted by Android DownloadManager previously. When all the download are handled by native, we should use native infobar implementation. The only exception is OMA DRM download, but those files are not considered dangerous. TBR=dfalcantara@chromium.org BUG=654048 Review-Url: https://codereview.chromium.org/2437623003 Cr-Commit-Position: refs/heads/master@{#427428} (cherry picked from commit ad5764a975c7b084009ba19ed7c95a393b8b3b23) Committed: https://chromium.googlesource.com/chromium/src/+/b7620c145dcabaef1925b113a46637fcdc30cb4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -179 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 6 chunks +4 lines, -84 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/download/chrome_download_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/download/chrome_download_delegate.cc View 2 chunks +0 lines, -24 lines 0 comments Download
A chrome/browser/android/download/dangerous_download_infobar_delegate.h View 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/android/download/dangerous_download_infobar_delegate.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/browser/android/download/download_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/download/download_controller.cc View 4 chunks +13 lines, -23 lines 0 comments Download
M chrome/browser/android/download/download_controller_base.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/download/mock_download_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/download/mock_download_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years, 1 month ago (2016-11-11 18:38:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7620c145dcabaef1925b113a46637fcdc30cb4f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698