Use native implementation of dangerous download infobar

Use native implementation of dangerous download infobar

Currently the dangerous download infobar is implemented in java.
This is because some of the download is intercepted by
Android DownloadManager previously.
When all the download are handled by native, we should use native
infobar implementation.
The only exception is OMA DRM download, but those files are not
considered dangerous.

BUG=654048
Committed: https://crrev.com/ad5764a975c7b084009ba19ed7c95a393b8b3b23
Cr-Commit-Position: refs/heads/master@{#427428}

[qinmin, 2016-10-19 20:02:43]

Patchset #1 (id:1) has been deleted

[qinmin, 2016-10-19 23:06:29]

Patchset #1 (id:20001) has been deleted

[qinmin, 2016-10-20 22:31:34]

qinmin@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[qinmin, 2016-10-20 22:31:35]

PTAL

[gone, 2016-10-24 18:08:56]

lgtm

https://codereview.chromium.org/2437623003/diff/40001/chrome/browser/android/...
File chrome/browser/android/download/dangerous_download_infobar_delegate.cc
(right):

https://codereview.chromium.org/2437623003/diff/40001/chrome/browser/android/...
chrome/browser/android/download/dangerous_download_infobar_delegate.cc:69: if
(download_item_) {
nit: do you need braces here?  you didn't use them up on line 32.

[qinmin, 2016-10-24 23:35:30]

https://codereview.chromium.org/2437623003/diff/40001/chrome/browser/android/...
File chrome/browser/android/download/dangerous_download_infobar_delegate.cc
(right):

https://codereview.chromium.org/2437623003/diff/40001/chrome/browser/android/...
chrome/browser/android/download/dangerous_download_infobar_delegate.cc:69: if
(download_item_) {
On 2016/10/24 18:08:56, dfalcantara (slow 10.24) wrote:
> nit: do you need braces here?  you didn't use them up on line 32.

All brackets for single line if statement are removed.

[qinmin, 2016-10-25 17:38:06]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-10-25 17:38:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2437623003/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-10-25 17:38:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:55:09]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-25 19:09:22]

Description was changed from

==========
Use native implementation of dangerous download infobar

Currently the dangerous download infobar is implemented in java.
This is because some of the download is intercepted by
Android DownloadManager previously.
When all the download are handled by native, we should use native
infobar implementation.
The only exception is OMA DRM download, but those files are not
considered dangerous.

BUG=654048
==========

to

==========
Use native implementation of dangerous download infobar

Currently the dangerous download infobar is implemented in java.
This is because some of the download is intercepted by
Android DownloadManager previously.
When all the download are handled by native, we should use native
infobar implementation.
The only exception is OMA DRM download, but those files are not
considered dangerous.

BUG=654048

Committed: https://crrev.com/ad5764a975c7b084009ba19ed7c95a393b8b3b23
Cr-Commit-Position: refs/heads/master@{#427428}
==========

[commit-bot: I haz the power, 2016-10-25 19:09:23]

Patchset 2 (id:??) landed as
https://crrev.com/ad5764a975c7b084009ba19ed7c95a393b8b3b23
Cr-Commit-Position: refs/heads/master@{#427428}