Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py

Issue 2496903004: Making ref range failure messages more explicit. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py b/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
index 8b3c89de6e43c8ec21a6db7809760b8479b9ba8c..927653f3a12a200c96cf17c2a117c4f46311dd7f 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
@@ -97,6 +97,7 @@ class RevisionState(object):
self.debug_values = []
self.return_codes = []
self._test_config = None
+ self.failure_reason = None
if self.bisector.test_type == 'perf':
self.repeat_count = MINIMUM_SAMPLE_SIZE
@@ -161,6 +162,9 @@ class RevisionState(object):
""")
if self._is_build_failed():
self.failed = True
+ self.failure_reason = (
+ 'Failed to compile revision %s. Buildbucket job id %s' % (
+ self.revision_string(), self.build_id))
return
self._do_test()
@@ -169,9 +173,11 @@ class RevisionState(object):
min(self, self.bisector.lkgr, self.bisector.fkbr,
key=lambda(x): x.test_run_count)._do_test()
- except bisect_exceptions.UntestableRevisionException:
+ except bisect_exceptions.UntestableRevisionException as e:
+ self.failure_reason = e.message
self.failed = True
+
def deps_change(self):
"""Uses `git show` to see if a given commit contains a DEPS change."""
# Avoid checking DEPS changes for dependency repo revisions.
@@ -319,7 +325,8 @@ class RevisionState(object):
self.failed = True
if 'MISSING_METRIC' in results.get('errors'):
self.bisector.surface_result('MISSING_METRIC')
- raise bisect_exceptions.UntestableRevisionException(results['errors'])
+ raise bisect_exceptions.UntestableRevisionException(
+ 'The metric was not found in the output.')
elif self.bisector.is_return_code_mode():
assert len(results['retcodes'])
else:

Powered by Google App Engine
This is Rietveld 408576698