Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py

Issue 2496903004: Making ref range failure messages more explicit. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py b/scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py
index 0a511704a9f5ca98a9e6c8a6d50da2e107e3270f..36438e0665d60330fe109f9dadb79b34c73adbf5 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py
@@ -81,12 +81,14 @@ def _gather_reference_range(bisector): # pragma: no cover
bisector.surface_result('REF_RANGE_FAIL')
bisector.failed = True
raise bisect_exceptions.InconclusiveBisectException(
- 'Testing the "good" revision failed')
+ 'Testing the "good" revision failed: ' +
+ bisector.good_rev.failure_reason)
elif bisector.bad_rev.failed:
bisector.surface_result('REF_RANGE_FAIL')
bisector.failed = True
raise bisect_exceptions.InconclusiveBisectException(
- 'Testing the "bad" revision failed')
+ 'Testing the "bad" revision failed: ' +
+ bisector.bad_rev.failure_reason)
def _bisect_main_loop(bisector): # pragma: no cover
"""This is the main bisect loop.

Powered by Google App Engine
This is Rietveld 408576698