Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2496813002: [Command buffer] workaround the framebuffer completeness bug for Intel Mac (Closed)
Patch Set: apply the workaround to all Mac vendors, not only Mac Intel Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 8be63b095c41b3833ddc5b4f8029d28cf47203c0..c54c410d09f45e30dfc9d7d3cbba2c4f899631d4 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -7542,6 +7542,29 @@ GLenum GLES2DecoderImpl::DoCheckFramebufferStatus(GLenum target) {
if (completeness != GL_FRAMEBUFFER_COMPLETE) {
return completeness;
}
+
+ if (workarounds().adjust_framebuffer_complete_status &&
+ SupportsDrawBuffers()) {
+ switch (target) {
+ case GL_READ_FRAMEBUFFER:
+ if (framebuffer->ReadBufferHasNoImage() &&
+ framebuffer->ColorBuffersHaveImage()) {
+ return GL_FRAMEBUFFER_COMPLETE;
+ }
+ break;
+ case GL_DRAW_FRAMEBUFFER:
+ case GL_FRAMEBUFFER:
+ if (framebuffer->DrawBuffersHaveNoImage() &&
+ framebuffer->ColorBuffersHaveImage()) {
+ return GL_FRAMEBUFFER_COMPLETE;
+ }
+ break;
+ default:
+ NOTREACHED();
+ break;
+ }
+ }
+
return framebuffer->GetStatus(texture_manager(), target);
}

Powered by Google App Engine
This is Rietveld 408576698