chrome/browser/ui/autofill/autofill_popup_controller_impl.h - Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)

Patch Set: address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h

index c39dc6d6328ef85db8cba6cbe77cf1c49dec15bf..5e7f869ada865bc232b6ed92fa955d16e4e0496e 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h

@@ -76,7 +76,6 @@ class AutofillPopupControllerImpl : public AutofillPopupController {

bool AcceptSelectedLine() override;

void SelectionCleared() override;

void AcceptSuggestion(size_t index) override;

- bool IsWarning(size_t index) const override;

gfx::Rect popup_bounds() const override;

gfx::NativeView container_view() override;

const gfx::RectF& element_bounds() const override;