Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4205)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)
Patch Set: address review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
index cdf963fd316b1e7ef83a959e569b8d55b85489d2..a1e4ee0ede96cdbbaa1a54144be680706e526fde 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
@@ -287,10 +287,6 @@ void AutofillPopupControllerImpl::AcceptSuggestion(size_t index) {
index);
}
-bool AutofillPopupControllerImpl::IsWarning(size_t index) const {
- return suggestions_[index].frontend_id == POPUP_ITEM_ID_WARNING_MESSAGE;
-}
-
gfx::Rect AutofillPopupControllerImpl::popup_bounds() const {
return layout_model_.popup_bounds();
}
@@ -460,8 +456,12 @@ bool AutofillPopupControllerImpl::RemoveSelectedLine() {
}
bool AutofillPopupControllerImpl::CanAccept(int id) {
- return id != POPUP_ITEM_ID_SEPARATOR && id != POPUP_ITEM_ID_WARNING_MESSAGE &&
- id != POPUP_ITEM_ID_TITLE;
+ // TODO(lshang): Make POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE clickable
+ // and redirect to chrome security connection help center page.
+ return id != POPUP_ITEM_ID_SEPARATOR &&
+ id != POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE &&
+ id != POPUP_ITEM_ID_TITLE &&
+ id != POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
}
bool AutofillPopupControllerImpl::HasSuggestions() {

Powered by Google App Engine
This is Rietveld 408576698