Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)
Patch Set: update Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 7923e0bc9d51d4e5a73f839cdc7157eba4654d9e..d7e7cfcf3e2bb6bb3f98cf20f8441a302e74f6fc 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -569,7 +569,8 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
// Autofill is disabled for a website.
Suggestion warning_suggestion(l10n_util::GetStringUTF16(
IDS_AUTOFILL_WARNING_INSECURE_CONNECTION));
- warning_suggestion.frontend_id = POPUP_ITEM_ID_WARNING_MESSAGE;
+ warning_suggestion.frontend_id =
+ POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE;
suggestions.assign(1, warning_suggestion);
// On top of the explanation message, first show a "Payment not secure"
@@ -578,7 +579,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
Suggestion cc_field_http_warning_suggestion(l10n_util::GetStringUTF16(
IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE));
cc_field_http_warning_suggestion.frontend_id =
- POPUP_ITEM_ID_WARNING_MESSAGE;
+ POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
suggestions.insert(suggestions.begin(),
cc_field_http_warning_suggestion);
}

Powered by Google App Engine
This is Rietveld 408576698