Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: components/autofill/core/browser/autofill_external_delegate_unittest.cc

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)
Patch Set: update Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate_unittest.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate_unittest.cc b/components/autofill/core/browser/autofill_external_delegate_unittest.cc
index 709c73444dd972f09f0a395cfcddbeb6dc926b87..d0e28d5476ddd1cb49aa4d35932a6b77ff185aff 100644
--- a/components/autofill/core/browser/autofill_external_delegate_unittest.cc
+++ b/components/autofill/core/browser/autofill_external_delegate_unittest.cc
@@ -463,16 +463,15 @@ TEST_F(AutofillExternalDelegateUnitTest, AutofillWarnings) {
EXPECT_CALL(
autofill_client_,
ShowAutofillPopup(
- _,
- _,
- SuggestionVectorIdsAre(testing::ElementsAre(
- static_cast<int>(POPUP_ITEM_ID_WARNING_MESSAGE))),
+ _, _, SuggestionVectorIdsAre(testing::ElementsAre(static_cast<int>(
+ POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE))),
_));
// This should call ShowAutofillPopup.
std::vector<Suggestion> autofill_item;
autofill_item.push_back(Suggestion());
- autofill_item[0].frontend_id = POPUP_ITEM_ID_WARNING_MESSAGE;
+ autofill_item[0].frontend_id =
+ POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE;
external_delegate_->OnSuggestionsReturned(kQueryId, autofill_item);
}
@@ -493,9 +492,10 @@ TEST_F(AutofillExternalDelegateUnitTest,
// This should call ShowAutofillPopup.
std::vector<Suggestion> suggestions;
suggestions.push_back(Suggestion());
- suggestions[0].frontend_id = POPUP_ITEM_ID_WARNING_MESSAGE;
+ suggestions[0].frontend_id = POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
suggestions.push_back(Suggestion());
- suggestions[1].frontend_id = POPUP_ITEM_ID_WARNING_MESSAGE;
+ suggestions[1].frontend_id =
+ POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE;
suggestions.push_back(Suggestion());
suggestions[2].value = ASCIIToUTF16("Rick");
suggestions[2].frontend_id = POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY;
« no previous file with comments | « components/autofill/core/browser/autofill_external_delegate.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698