Http Bad: Add a PopupItemId to identify http warning message

components/autofill/core/browser/autofill_manager.cc

Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 7923e0bc9d51d4e5a73f839cdc7157eba4654d9e..d7e7cfcf3e2bb6bb3f98cf20f8441a302e74f6fc 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -569,7 +569,8 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
         // Autofill is disabled for a website.
         Suggestion warning_suggestion(l10n_util::GetStringUTF16(
             IDS_AUTOFILL_WARNING_INSECURE_CONNECTION));
-        warning_suggestion.frontend_id = POPUP_ITEM_ID_WARNING_MESSAGE;
+        warning_suggestion.frontend_id =
+            POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE;

[csashi, 2016/11/17 01:41:31]

Unrelated to this change, but may be have a suggestion constructor that takes
string and frontend_id? There are many places where we create suggestion and
immediately fill in frontend_id.

[lshang, 2016/11/17 07:03:46]

I moved this block of code into an method in the following CL, cause by then we
need to handle icon and label as well, so it's better to move the block into a
method in the anonymous namespace.

Suggestion has a constructor which takes in all value, label, icon and
frontend_id, but don't have constructor which takes only value and frontend_id.
I think create suggestion and immediately fill in frontend_id is fine here, it
doesn't make too much difference in performance and it's more clear to indicate
the frontend_id:-)

         suggestions.assign(1, warning_suggestion);
 
         // On top of the explanation message, first show a "Payment not secure"
@@ -578,7 +579,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
           Suggestion cc_field_http_warning_suggestion(l10n_util::GetStringUTF16(
               IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE));
           cc_field_http_warning_suggestion.frontend_id =
-              POPUP_ITEM_ID_WARNING_MESSAGE;
+              POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
           suggestions.insert(suggestions.begin(),
                              cc_field_http_warning_suggestion);
         }