Http Bad: Add a PopupItemId to identify http warning message

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 551 matching lines @@
         AutofillMetrics::LogIsQueriedCreditCardFormSecure(is_context_secure);
 
       // Don't provide credit card suggestions for non-secure pages, but do
       // provide them for secure pages with passive mixed content (see impl. of
       // IsContextSecure).
       if (is_filling_credit_card && !is_context_secure) {
         // Replace the suggestion content with a warning message explaining why
         // Autofill is disabled for a website.
         Suggestion warning_suggestion(l10n_util::GetStringUTF16(
             IDS_AUTOFILL_WARNING_INSECURE_CONNECTION));
-        warning_suggestion.frontend_id = POPUP_ITEM_ID_WARNING_MESSAGE;
+        warning_suggestion.frontend_id =
+            POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE;

[csashi, 2016/11/17 01:41:31]

Unrelated to this change, but may be have a suggestion constructor that takes
string and frontend_id? There are many places where we create suggestion and
immediately fill in frontend_id.

[lshang, 2016/11/17 07:03:46]

I moved this block of code into an method in the following CL, cause by then we
need to handle icon and label as well, so it's better to move the block into a
method in the anonymous namespace.

Suggestion has a constructor which takes in all value, label, icon and
frontend_id, but don't have constructor which takes only value and frontend_id.
I think create suggestion and immediately fill in frontend_id is fine here, it
doesn't make too much difference in performance and it's more clear to indicate
the frontend_id:-)

         suggestions.assign(1, warning_suggestion);
 
         // On top of the explanation message, first show a "Payment not secure"
         // message.
         if (IsCreditCardAutofillHttpWarningEnabled()) {
           Suggestion cc_field_http_warning_suggestion(l10n_util::GetStringUTF16(
               IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE));
           cc_field_http_warning_suggestion.frontend_id =
-              POPUP_ITEM_ID_WARNING_MESSAGE;
+              POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
           suggestions.insert(suggestions.begin(),
                              cc_field_http_warning_suggestion);
         }
       } else {
         bool section_is_autofilled =
             SectionIsAutofilled(*form_structure, form,
                                 autofill_field->section());
         if (section_is_autofilled) {
           // If the relevant section is auto-filled and the renderer is querying
           // for suggestions, then the user is editing the value of a field.
@@ skipping 1511 matching lines @@
     if (i > 0)
       fputs("Next oldest form:\n", file);
   }
   fputs("\n", file);
 
   fclose(file);
 }
 #endif  // ENABLE_FORM_DEBUG_DUMP
 
 }  // namespace autofill