Http Bad: Add a PopupItemId to identify http warning message

chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

Index: chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc b/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
index 4831ed76649608fcfd8b14888a77897f16d5f8d2..b3ce678f84b03b47d62cb491a4ef1fa3a95eec14 100644
--- a/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
@@ -81,8 +81,8 @@ void AutofillPopupViewViews::DrawAutofillEntry(gfx::Canvas* canvas,
   canvas->DrawStringRectWithFlags(
       controller_->GetElidedValueAt(index),
       controller_->layout_model().GetValueFontListForRow(index),
-      controller_->IsWarning(index) ? kLabelTextColor : kValueTextColor,

[lshang, 2016/11/15 07:25:19]

Didn't remove IsWarning() because it is also used on Mac[1].

[1]:https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm?q=IsWarning&sq=package:chromium&l=199&dr=C

[Mathieu, 2016/11/16 05:09:46]

Can you make a change (now or later) to use GetValueFontColorForRow on Mac? You
can transfer the SkColor to NSColor
https://cs.chromium.org/chromium/src/skia/ext/skia_utils_mac.h?rcl=0&l=64

[lshang, 2016/11/16 09:34:23]

A TODO is added. I'll address this in a separate CL.

-      value_rect, text_align);
+      controller_->layout_model().GetValueFontColorForRow(index), value_rect,
+      text_align);
 
   // Use this to figure out where all the other Autofill items should be placed.
   int x_align_left =