Http Bad: Add a PopupItemId to identify http warning message

chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_popup_view_views.h"
 
 #include "chrome/browser/ui/autofill/autofill_popup_controller.h"
 #include "chrome/browser/ui/autofill/autofill_popup_layout_model.h"
 #include "chrome/browser/ui/autofill/popup_constants.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
@@ skipping 63 matching lines @@
   canvas->FillRect(entry_rect, controller_->GetBackgroundColorForRow(index));
 
   const bool is_rtl = controller_->IsRTL();
   const int text_align =
       is_rtl ? gfx::Canvas::TEXT_ALIGN_RIGHT : gfx::Canvas::TEXT_ALIGN_LEFT;
   gfx::Rect value_rect = entry_rect;
   value_rect.Inset(AutofillPopupLayoutModel::kEndPadding, 0);
   canvas->DrawStringRectWithFlags(
       controller_->GetElidedValueAt(index),
       controller_->layout_model().GetValueFontListForRow(index),
-      controller_->IsWarning(index) ? kLabelTextColor : kValueTextColor,

[lshang, 2016/11/15 07:25:19]

Didn't remove IsWarning() because it is also used on Mac[1].

[1]:https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm?q=IsWarning&sq=package:chromium&l=199&dr=C

[Mathieu, 2016/11/16 05:09:46]

Can you make a change (now or later) to use GetValueFontColorForRow on Mac? You
can transfer the SkColor to NSColor
https://cs.chromium.org/chromium/src/skia/ext/skia_utils_mac.h?rcl=0&l=64

[lshang, 2016/11/16 09:34:23]

A TODO is added. I'll address this in a separate CL.

-      value_rect, text_align);
+      controller_->layout_model().GetValueFontColorForRow(index), value_rect,
+      text_align);
 
   // Use this to figure out where all the other Autofill items should be placed.
   int x_align_left =
       is_rtl ? AutofillPopupLayoutModel::kEndPadding
              : entry_rect.right() - AutofillPopupLayoutModel::kEndPadding;
 
   // Draw the Autofill icon, if one exists
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   int row_height = controller_->layout_model().GetRowBounds(index).height();
   if (!controller_->GetSuggestionAt(index).icon.empty()) {
@@ skipping 34 matching lines @@
 
   // If the top level widget can't be found, cancel the popup since we can't
   // fully set it up.
   if (!observing_widget)
     return NULL;
 
   return new AutofillPopupViewViews(controller, observing_widget);
 }
 
 }  // namespace autofill