Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: content/renderer/cache_storage/cache_storage_dispatcher.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)
Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/cache_storage/cache_storage_dispatcher.h
diff --git a/content/renderer/cache_storage/cache_storage_dispatcher.h b/content/renderer/cache_storage/cache_storage_dispatcher.h
index 53dc84fcc662d854e2b43c7b4f1fb0498f5d00e9..ab93960cf396187dac7c1745fef21e3197dbe1fb 100644
--- a/content/renderer/cache_storage/cache_storage_dispatcher.h
+++ b/content/renderer/cache_storage/cache_storage_dispatcher.h
@@ -166,26 +166,25 @@ class CacheStorageDispatcher : public WorkerThread::Observer {
private:
class WebCache;
- typedef IDMap<blink::WebServiceWorkerCacheStorage::CacheStorageCallbacks,
- IDMapOwnPointer> CallbacksMap;
- typedef IDMap<
- blink::WebServiceWorkerCacheStorage::CacheStorageWithCacheCallbacks,
- IDMapOwnPointer> WithCacheCallbacksMap;
- typedef IDMap<blink::WebServiceWorkerCacheStorage::CacheStorageKeysCallbacks,
- IDMapOwnPointer> KeysCallbacksMap;
- typedef IDMap<blink::WebServiceWorkerCacheStorage::CacheStorageMatchCallbacks,
- IDMapOwnPointer> StorageMatchCallbacksMap;
-
- typedef base::hash_map<int32_t, base::TimeTicks> TimeMap;
-
- typedef IDMap<blink::WebServiceWorkerCache::CacheMatchCallbacks,
- IDMapOwnPointer> MatchCallbacksMap;
- typedef IDMap<blink::WebServiceWorkerCache::CacheWithResponsesCallbacks,
- IDMapOwnPointer> WithResponsesCallbacksMap;
- typedef IDMap<blink::WebServiceWorkerCache::CacheWithRequestsCallbacks,
- IDMapOwnPointer> WithRequestsCallbacksMap;
+ using CallbacksMap = IDMap<std::unique_ptr<
+ blink::WebServiceWorkerCacheStorage::CacheStorageCallbacks>>;
+ using WithCacheCallbacksMap = IDMap<std::unique_ptr<
+ blink::WebServiceWorkerCacheStorage::CacheStorageWithCacheCallbacks>>;
+ using KeysCallbacksMap = IDMap<std::unique_ptr<
+ blink::WebServiceWorkerCacheStorage::CacheStorageKeysCallbacks>>;
+ using StorageMatchCallbacksMap = IDMap<std::unique_ptr<
+ blink::WebServiceWorkerCacheStorage::CacheStorageMatchCallbacks>>;
+
+ using TimeMap = base::hash_map<int32_t, base::TimeTicks>;
+
+ using MatchCallbacksMap =
+ IDMap<std::unique_ptr<blink::WebServiceWorkerCache::CacheMatchCallbacks>>;
+ using WithResponsesCallbacksMap = IDMap<std::unique_ptr<
+ blink::WebServiceWorkerCache::CacheWithResponsesCallbacks>>;
+ using WithRequestsCallbacksMap = IDMap<std::unique_ptr<
+ blink::WebServiceWorkerCache::CacheWithRequestsCallbacks>>;
using BatchCallbacksMap =
- IDMap<blink::WebServiceWorkerCache::CacheBatchCallbacks, IDMapOwnPointer>;
+ IDMap<std::unique_ptr<blink::WebServiceWorkerCache::CacheBatchCallbacks>>;
static int32_t CurrentWorkerId() { return WorkerThread::GetCurrentId(); }
@@ -211,7 +210,7 @@ class CacheStorageDispatcher : public WorkerThread::Observer {
TimeMap match_times_;
// The individual caches created under this CacheStorage object.
- IDMap<WebCache, IDMapExternalPointer> web_caches_;
+ IDMap<WebCache*> web_caches_;
// These ID maps are held in the CacheStorage object rather than the Cache
// object to ensure that the IDs are unique.
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin_manager.cc ('k') | content/renderer/dom_storage/webstoragearea_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698