content/renderer/browser_plugin/browser_plugin_manager.cc - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager.cc

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/browser_plugin/browser_plugin_manager.cc

diff --git a/content/renderer/browser_plugin/browser_plugin_manager.cc b/content/renderer/browser_plugin/browser_plugin_manager.cc

index 19820735f37648ffda9a51cb8979505957dac211..a9236a76657c8d0a4ba0a414ac8cff27d99df180 100644

--- a/content/renderer/browser_plugin/browser_plugin_manager.cc

+++ b/content/renderer/browser_plugin/browser_plugin_manager.cc

@@ -49,7 +49,7 @@ int BrowserPluginManager::GetNextInstanceID() {

}

void BrowserPluginManager::UpdateFocusState() {

- IDMap<BrowserPlugin>::iterator iter(&instances_);

+ IDMap<BrowserPlugin*>::iterator iter(&instances_);

while (!iter.IsAtEnd()) {

iter.GetCurrentValue()->UpdateGuestFocusState(blink::WebFocusTypeNone);

iter.Advance();

@@ -76,7 +76,7 @@ BrowserPlugin* BrowserPluginManager::CreateBrowserPlugin(

void BrowserPluginManager::DidCommitCompositorFrame(

int render_frame_routing_id) {

- IDMap<BrowserPlugin>::iterator iter(&instances_);

+ IDMap<BrowserPlugin*>::iterator iter(&instances_);

while (!iter.IsAtEnd()) {

if (iter.GetCurrentValue()->render_frame_routing_id() ==

render_frame_routing_id) {