content/browser/service_worker/service_worker_dispatcher_host.h - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_dispatcher_host.h

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.h b/content/browser/service_worker/service_worker_dispatcher_host.h

index 260a07d19a9d7c4abe2db5ec2b4c2ada9b50af7a..08c5698c48f1bccae2d712c24663c58f4fc37f75 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.h

+++ b/content/browser/service_worker/service_worker_dispatcher_host.h

@@ -275,10 +275,10 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost

ResourceContext* resource_context_;

scoped_refptr<ServiceWorkerContextWrapper> context_wrapper_;

- IDMap<ServiceWorkerHandle, IDMapOwnPointer> handles_;

+ IDMap<std::unique_ptr<ServiceWorkerHandle>> handles_;

using RegistrationHandleMap =

- IDMap<ServiceWorkerRegistrationHandle, IDMapOwnPointer>;

+ IDMap<std::unique_ptr<ServiceWorkerRegistrationHandle>>;

RegistrationHandleMap registration_handles_;

bool channel_ready_; // True after BrowserMessageFilter::sender_ != NULL.