content/browser/service_worker/service_worker_dispatcher_host.cc - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_dispatcher_host.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc

index 5a5dc4c9f082867514628bdb954e39954c31ab5c..ed7b357561fe7906d4c167ab13b5ee0316d19e17 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc

@@ -244,7 +244,7 @@ void ServiceWorkerDispatcherHost::RegisterServiceWorkerRegistrationHandle(

ServiceWorkerHandle* ServiceWorkerDispatcherHost::FindServiceWorkerHandle(

int provider_id,

int64_t version_id) {

- for (IDMap<ServiceWorkerHandle, IDMapOwnPointer>::iterator iter(&handles_);

+ for (IDMap<std::unique_ptr<ServiceWorkerHandle>>::iterator iter(&handles_);

!iter.IsAtEnd(); iter.Advance()) {

ServiceWorkerHandle* handle = iter.GetCurrentValue();

DCHECK(handle);