Fix unsized internalformat color-renderable detection

Fix unsized internalformat color-renderable detection

GenerateMipmap requires an unsized internal format or color-renderable
and texture-filterable sized internal format, es_spec_3.0.4 page 160.

For unsized internal format, only RGBA and RGB are color-renderable,
in section 4.4.4 Framebuffer Completeness, es_spec_3.0.4, page 212.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8c28970babf05637d242b861eb46efe690911cc2
Cr-Commit-Position: refs/heads/master@{#433100}

[qiankun, 2016-11-11 14:47:57]

Description was changed from

==========
Fix unsized internalformat color-renderable detection

GenerateMipmap requires an unsized internal format or colore-renderable
and texture-filterable sized internal format, es_spec_3.0.4 page 160.

For unsized internal format, only RGBA and RGB are color-renderable,
in section 4.4.4 Framebuffer Completeness, es_spec_3.0.4, page 212.

BUG=612542
==========

to

==========
Fix unsized internalformat color-renderable detection

GenerateMipmap requires an unsized internal format or colore-renderable
and texture-filterable sized internal format, es_spec_3.0.4 page 160.

For unsized internal format, only RGBA and RGB are color-renderable,
in section 4.4.4 Framebuffer Completeness, es_spec_3.0.4, page 212.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2016-11-11 15:31:45]

qiankun.miao@intel.com changed reviewers:
+ kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2016-11-11 15:31:46]

PTAL

[Ken Russell (switch to Gerrit), 2016-11-11 21:17:13]

Description was changed from

==========
Fix unsized internalformat color-renderable detection

GenerateMipmap requires an unsized internal format or colore-renderable
and texture-filterable sized internal format, es_spec_3.0.4 page 160.

For unsized internal format, only RGBA and RGB are color-renderable,
in section 4.4.4 Framebuffer Completeness, es_spec_3.0.4, page 212.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix unsized internalformat color-renderable detection

GenerateMipmap requires an unsized internal format or color-renderable
and texture-filterable sized internal format, es_spec_3.0.4 page 160.

For unsized internal format, only RGBA and RGB are color-renderable,
in section 4.4.4 Framebuffer Completeness, es_spec_3.0.4, page 212.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-11 21:18:45]

Are there tests to cover this code change?

[Ken Russell (switch to Gerrit), 2016-11-11 21:20:27]

On 2016/11/11 21:18:45, Ken Russell wrote:
> Are there tests to cover this code change?

FYI, I filed http://crbug.com/664623 about the win_chromium_dbg_ng test failure.
If you see similar test flakes in the future please scan the bug database and
file a bug about them if none is filed -- and add a link to your failure if one
is filed. Thanks.

[Zhenyao Mo, 2016-11-11 21:30:06]

The code looks fine to me, but I agree with kbr - can you add a conformance test
first, which will be failing without this CL and passing with it.

[qiankun, 2016-11-14 11:58:28]

On 2016/11/11 21:30:06, Zhenyao Mo wrote:
> The code looks fine to me, but I agree with kbr - can you add a conformance
test
> first, which will be failing without this CL and passing with it.

In fact, the generateMipmap is validated correctly though
Texture::ColorRenderable is wrong. This patch doesn't change the validation
result of generateMipmap. And no other place uses Texture::ColorRenderable. So,
no conformance test is needed. Unit tests were added.

[Zhenyao Mo, 2016-11-14 19:49:36]

LGTM with one thing fixed.

[Zhenyao Mo, 2016-11-14 19:49:44]

https://codereview.chromium.org/2496633005/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/2496633005/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/texture_manager.cc:876: return internal_format ==
GL_RGBA || internal_format == GL_RGB ||
Actually let's stick to the != ALPHA != LUMINANCE code. Other extensions might
also have color-renderable unsized formats, say RED or RG.

[qiankun, 2016-11-16 23:41:56]

The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 23:42:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 01:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:54:33]

Dry run: This issue passed the CQ dry run.

[qiankun, 2016-11-18 02:10:18]

The CQ bit was checked by qiankun.miao@intel.com

[qiankun, 2016-11-18 02:10:19]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2496633005/#ps60001
(title: "fix comments of zmo")

[commit-bot: I haz the power, 2016-11-18 02:11:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qiankun, 2016-11-18 03:20:38]

Landing it now.

https://codereview.chromium.org/2496633005/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/2496633005/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/texture_manager.cc:876: return internal_format ==
GL_RGBA || internal_format == GL_RGB ||
On 2016/11/14 19:49:44, Zhenyao Mo wrote:
> Actually let's stick to the != ALPHA != LUMINANCE code. Other extensions might
> also have color-renderable unsized formats, say RED or RG.

Done.

[Zhenyao Mo, 2016-11-18 03:36:01]

The CQ bit was unchecked by zmo@chromium.org

[Zhenyao Mo, 2016-11-18 03:36:34]

On 2016/11/18 03:20:38, qiankun wrote:
> Landing it now.
> 
>
https://codereview.chromium.org/2496633005/diff/40001/gpu/command_buffer/serv...
> File gpu/command_buffer/service/texture_manager.cc (right):
> 
>
https://codereview.chromium.org/2496633005/diff/40001/gpu/command_buffer/serv...
> gpu/command_buffer/service/texture_manager.cc:876: return internal_format ==
> GL_RGBA || internal_format == GL_RGB ||
> On 2016/11/14 19:49:44, Zhenyao Mo wrote:
> > Actually let's stick to the != ALPHA != LUMINANCE code. Other extensions
might
> > also have color-renderable unsized formats, say RED or RG.
> 
> Done.

Let's wait a bit until a few critical ones land. Otherwise there will be
conflict and the critical ones may fail to apply.

[Zhenyao Mo, 2016-11-18 04:19:28]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-11-18 04:20:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 04:26:40]

Description was changed from

==========
Fix unsized internalformat color-renderable detection

GenerateMipmap requires an unsized internal format or color-renderable
and texture-filterable sized internal format, es_spec_3.0.4 page 160.

For unsized internal format, only RGBA and RGB are color-renderable,
in section 4.4.4 Framebuffer Completeness, es_spec_3.0.4, page 212.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix unsized internalformat color-renderable detection

GenerateMipmap requires an unsized internal format or color-renderable
and texture-filterable sized internal format, es_spec_3.0.4 page 160.

For unsized internal format, only RGBA and RGB are color-renderable,
in section 4.4.4 Framebuffer Completeness, es_spec_3.0.4, page 212.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-18 04:26:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-18 04:33:02]

Description was changed from

==========
Fix unsized internalformat color-renderable detection

GenerateMipmap requires an unsized internal format or color-renderable
and texture-filterable sized internal format, es_spec_3.0.4 page 160.

For unsized internal format, only RGBA and RGB are color-renderable,
in section 4.4.4 Framebuffer Completeness, es_spec_3.0.4, page 212.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix unsized internalformat color-renderable detection

GenerateMipmap requires an unsized internal format or color-renderable
and texture-filterable sized internal format, es_spec_3.0.4 page 160.

For unsized internal format, only RGBA and RGB are color-renderable,
in section 4.4.4 Framebuffer Completeness, es_spec_3.0.4, page 212.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8c28970babf05637d242b861eb46efe690911cc2
Cr-Commit-Position: refs/heads/master@{#433100}
==========

[commit-bot: I haz the power, 2016-11-18 04:33:03]

Patchset 4 (id:??) landed as
https://crrev.com/8c28970babf05637d242b861eb46efe690911cc2
Cr-Commit-Position: refs/heads/master@{#433100}