W3C auto importer: Add a buildbot job link to CL description.

W3C auto importer: Add a buildbot job link to CL description.

The purpose of this is to make it a little more convenient get
to the buildbot logs when debugging auto-import CLs.

BUG=621599
Committed: https://crrev.com/1a6cf4da7c27c9b66deb6dcd9dc98458536d952f
Cr-Commit-Position: refs/heads/master@{#431807}

[qyearsley, 2016-11-10 18:28:29]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[jeffcarp, 2016-11-10 19:08:00]

lgtm minus the one comment

https://codereview.chromium.org/2496633002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py
(right):

https://codereview.chromium.org/2496633002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py:187:
def __init__(self, output='', exit_code=0, exception=None, run_command_fn=None,
stderr='', ):
Is this intentional?

[qyearsley, 2016-11-10 19:20:28]

https://codereview.chromium.org/2496633002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py
(right):

https://codereview.chromium.org/2496633002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py:187:
def __init__(self, output='', exit_code=0, exception=None, run_command_fn=None,
stderr='', ):
On 2016/11/10 at 19:08:00, jeffcarp wrote:
> Is this intentional?

Nope, the comma wasn't intentional; now removed.

[qyearsley, 2016-11-10 19:42:31]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 19:42:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:48:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:48:57]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-11-11 17:23:36]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-11-11 17:23:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2496633002/#ps20001
(title: "Remove comma")

[commit-bot: I haz the power, 2016-11-11 17:23:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 17:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 17:28:31]

Failed to apply patch for
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:330
  error: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py: patch
does not apply

Patch:       third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
index
bac3312d8680453e5b230960a72c3712630d30d8..70fa9bda55524a1068557299f0749f864407c2c0
100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
@@ -330,16 +330,32 @@ class DepsUpdater(object):
     def _upload_cl(self):
         self.print_('## Uploading change list.')
         cc_list = self.get_directory_owners_to_cc()
-        last_commit_message = self.check_run(['git', 'log', '-1',
'--format=%B'])
-        commit_message = last_commit_message + 'TBR=qyearsley@chromium.org'
+        description = self._cl_description()
         self.git_cl.run([
             'upload',
             '-f',
             '--rietveld',
             '-m',
-            commit_message,
+            description,
         ] + ['--cc=' + email for email in cc_list])
 
+    def _cl_description(self):
+        description = self.check_run(['git', 'log', '-1', '--format=%B'])
+        build_link = self._build_link()
+        if build_link:
+            description += 'Build: %s\n\n' % build_link
+        description += 'TBR=qyearsley@chromium.org'
+        return description
+
+    def _build_link(self):
+        """Returns a link to a job, if running on buildbot."""
+        master_name = self.host.environ.get('BUILDBOT_MASTERNAME')
+        builder_name = self.host.environ.get('BUILDBOT_BUILDERNAME')
+        build_number = self.host.environ.get('BUILDBOT_BUILDNUMBER')
+        if not (master_name and builder_name and build_number):
+            return None
+        return 'https://build.chromium.org/p/%s/builders/%s/builds/%s' %
(master_name, builder_name, build_number)
+
     def get_directory_owners_to_cc(self):
         """Returns a list of email addresses to CC for the current import."""
         self.print_('## Gathering directory owners emails to CC.')

[qyearsley, 2016-11-13 17:23:06]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-11-13 17:23:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2496633002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-13 17:23:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-13 18:22:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-13 18:30:38]

Description was changed from

==========
W3C auto importer: Add a buildbot job link to CL description.

The purpose of this is to make it a little more convenient get
to the buildbot logs when debugging auto-import CLs.

BUG=621599
==========

to

==========
W3C auto importer: Add a buildbot job link to CL description.

The purpose of this is to make it a little more convenient get
to the buildbot logs when debugging auto-import CLs.

BUG=621599

Committed: https://crrev.com/1a6cf4da7c27c9b66deb6dcd9dc98458536d952f
Cr-Commit-Position: refs/heads/master@{#431807}
==========

[commit-bot: I haz the power, 2016-11-13 18:30:40]

Patchset 4 (id:??) landed as
https://crrev.com/1a6cf4da7c27c9b66deb6dcd9dc98458536d952f
Cr-Commit-Position: refs/heads/master@{#431807}