Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2496633002: W3C auto importer: Add a buildbot job link to CL description. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
index be88f0b1400fa7ba871f66209aeda51f0bbf0572..f20de4f3e6a9578410ff423938d8f47ddc489ee5 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
@@ -326,16 +326,32 @@ class DepsUpdater(object):
def _upload_cl(self):
_log.info('Uploading change list.')
cc_list = self.get_directory_owners_to_cc()
- last_commit_message = self.check_run(['git', 'log', '-1', '--format=%B'])
- commit_message = last_commit_message + 'TBR=qyearsley@chromium.org'
+ description = self._cl_description()
self.git_cl.run([
'upload',
'-f',
'--rietveld',
'-m',
- commit_message,
+ description,
] + ['--cc=' + email for email in cc_list])
+ def _cl_description(self):
+ description = self.check_run(['git', 'log', '-1', '--format=%B'])
+ build_link = self._build_link()
+ if build_link:
+ description += 'Build: %s\n\n' % build_link
+ description += 'TBR=qyearsley@chromium.org'
+ return description
+
+ def _build_link(self):
+ """Returns a link to a job, if running on buildbot."""
+ master_name = self.host.environ.get('BUILDBOT_MASTERNAME')
+ builder_name = self.host.environ.get('BUILDBOT_BUILDERNAME')
+ build_number = self.host.environ.get('BUILDBOT_BUILDNUMBER')
+ if not (master_name and builder_name and build_number):
+ return None
+ return 'https://build.chromium.org/p/%s/builders/%s/builds/%s' % (master_name, builder_name, build_number)
+
def get_directory_owners_to_cc(self):
"""Returns a list of email addresses to CC for the current import."""
_log.info('Gathering directory owners emails to CC.')

Powered by Google App Engine
This is Rietveld 408576698