Suppress text dump of JavaScript modal dialog messages in testharness.js tests

Suppress text dump of JavaScript modal dialog messages in testharness.js tests

Introduce testRunner.setDumpJavaScriptDialogs(), and set it to false in
testharnessreport.js.

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like to
suppress them for testharness.js-based tests in order to remove PASS-only
-expected.txt.

Committed: https://crrev.com/217ff8855ced140af1f6f95f69991d98503858dc
Cr-Commit-Position: refs/heads/master@{#431828}

[tkent, 2016-11-11 08:18:28]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 08:18:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-11-11 08:19:21]

Description was changed from

==========
Introduce window.testRunner.setDumpJavaScriptDialogs()

Text for JavaScript dialogs are dumped by default, but we'd like to suppress
them for testharness.js-based tests.
==========

to

==========
test_runner: Introduce testRunner.setDumpJavaScriptDialogs()

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like
to
suppress them for testharness.js-based tests.
==========

[tkent, 2016-11-11 09:03:10]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 09:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 10:27:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 10:27:56]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-11-11 12:14:51]

tkent@chromium.org changed reviewers:
+ kojii@chromium.org

[tkent, 2016-11-11 12:14:51]

kojii@, would you review this please?

[tkent, 2016-11-11 12:24:48]

Description was changed from

==========
test_runner: Introduce testRunner.setDumpJavaScriptDialogs()

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like
to
suppress them for testharness.js-based tests.
==========

to

==========
Suppress text dump of JavaScript modal dialog messages.

Introduce testRunner.setDumpJavaScriptDialogs(), and set it to false in
testharnessreport.js.

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like
to
suppress them for testharness.js-based tests.
==========

[tkent, 2016-11-14 01:47:31]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 01:47:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-11-14 03:28:11]

Description was changed from

==========
Suppress text dump of JavaScript modal dialog messages.

Introduce testRunner.setDumpJavaScriptDialogs(), and set it to false in
testharnessreport.js.

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like
to
suppress them for testharness.js-based tests.
==========

to

==========
Suppress text dump of JavaScript modal dialog messages in testharness.js tests

Introduce testRunner.setDumpJavaScriptDialogs(), and set it to false in
testharnessreport.js.

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like
to
suppress them for testharness.js-based tests.
==========

[commit-bot: I haz the power, 2016-11-14 03:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 03:29:03]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-11-14 04:31:35]

lgtm

[tkent, 2016-11-14 04:39:46]

Description was changed from

==========
Suppress text dump of JavaScript modal dialog messages in testharness.js tests

Introduce testRunner.setDumpJavaScriptDialogs(), and set it to false in
testharnessreport.js.

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like
to
suppress them for testharness.js-based tests.
==========

to

==========
Suppress text dump of JavaScript modal dialog messages in testharness.js tests

Introduce testRunner.setDumpJavaScriptDialogs(), and set it to false in
testharnessreport.js.

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like
to
suppress them for testharness.js-based tests in order to remove PASS-only
-expected.txt.
==========

[tkent, 2016-11-14 04:39:49]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-11-14 04:39:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 04:45:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-14 04:47:28]

Description was changed from

==========
Suppress text dump of JavaScript modal dialog messages in testharness.js tests

Introduce testRunner.setDumpJavaScriptDialogs(), and set it to false in
testharnessreport.js.

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like
to
suppress them for testharness.js-based tests in order to remove PASS-only
-expected.txt.
==========

to

==========
Suppress text dump of JavaScript modal dialog messages in testharness.js tests

Introduce testRunner.setDumpJavaScriptDialogs(), and set it to false in
testharnessreport.js.

Text for JavaScript dialogs are dumped by default in layout tests, but we'd like
to
suppress them for testharness.js-based tests in order to remove PASS-only
-expected.txt.

Committed: https://crrev.com/217ff8855ced140af1f6f95f69991d98503858dc
Cr-Commit-Position: refs/heads/master@{#431828}
==========

[commit-bot: I haz the power, 2016-11-14 04:47:29]

Patchset 2 (id:??) landed as
https://crrev.com/217ff8855ced140af1f6f95f69991d98503858dc
Cr-Commit-Position: refs/heads/master@{#431828}