Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: components/test_runner/test_runner.h

Issue 2496613003: Suppress text dump of JavaScript modal dialog messages in testharness.js tests (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/layout_test_runtime_flags.cc ('k') | components/test_runner/test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_runner.h
diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h
index 532868beb80c2fc15049ee97bb544004f9ce9147..5f93c52fb356ef0063d0ceff6d96c96a3ba03e54 100644
--- a/components/test_runner/test_runner.h
+++ b/components/test_runner/test_runner.h
@@ -173,6 +173,7 @@ class TestRunner : public WebTestRunner {
void DidCloseChooser();
bool ShouldDumpConsoleMessages() const;
+ bool ShouldDumpJavaScriptDialogs() const;
blink::WebEffectiveConnectionType effective_connection_type() const {
return effective_connection_type_;
@@ -472,6 +473,10 @@ class TestRunner : public WebTestRunner {
// to test output.
void SetDumpConsoleMessages(bool value);
+ // Controls whether JavaScript dialogs such as alert() are dumped to test
+ // output.
+ void SetDumpJavaScriptDialogs(bool value);
+
// Overrides the NetworkQualityEstimator's estimated network type. If |type|
// is TypeUnknown the NQE's value is used. Be sure to call this with
// TypeUnknown at the end of your test if you use this.
« no previous file with comments | « components/test_runner/layout_test_runtime_flags.cc ('k') | components/test_runner/test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698