Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/about_flags.cc

Issue 2496593002: Adding an experimental flag to block autoplay with sound in cross-origin iframes (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index bebdc7bf6ef5e6e4ec3d38228c96e4b2b796266c..07d728b7d28fbfc4b389aa0b643385f64ed46a2f 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1955,10 +1955,10 @@ const FeatureEntry kFeatureEntries[] = {
{"important-sites-in-cbd", IDS_FLAGS_IMPORTANT_SITES_IN_CBD_NAME,
IDS_FLAGS_IMPORTANT_SITES_IN_CBD_DESCRIPTION, kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)},
+#endif // OS_ANDROID
{"autoplay-muted-videos", IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_NAME,
- IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION, kOsAndroid,
+ IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION, kOsAll,
FEATURE_VALUE_TYPE(features::kAutoplayMutedVideos)},
-#endif // OS_ANDROID
{"enable-pointer-events", IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_NAME,
IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_DESCRIPTION, kOsAll,
FEATURE_VALUE_TYPE(features::kPointerEvents)},
@@ -2105,6 +2105,14 @@ const FeatureEntry kFeatureEntries[] = {
FEATURE_VALUE_TYPE(
offline_pages::kOfflinePagesSvelteConcurrentLoadingFeature)},
#endif
+#if !defined(OS_ANDROID)
+ {"media-playback-in-cross-origin-iframes-requires-user-gesture",
+ IDS_FLAGS_MEDIA_PLAYBACK_IN_CROSS_ORIGIN_IFRAMES_REQUIRES_USER_GESTURE_NAME,
+ IDS_FLAGS_MEDIA_PLAYBACK_IN_CROSS_ORIGIN_IFRAMES_REQUIRES_USER_GESTURE_DESCRIPTION,
+ kOsDesktop,
+ FEATURE_VALUE_TYPE(
+ features::kUserGestureRequiredForMediaPlaybackInCrossOriginIframes)},
+#endif
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

Powered by Google App Engine
This is Rietveld 408576698