Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2496593002: Adding an experimental flag to block autoplay with sound in cross-origin iframes (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index a0f34b66f7d98c3db9ead41896275692cb19d157..59118de3f06eb80c133318c413bf8a68a450f144 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -494,14 +494,19 @@ WebPreferences RenderViewHostImpl::ComputeWebkitPrefs() {
prefs.user_gesture_required_for_media_playback = !command_line.HasSwitch(
switches::kDisableGestureRequirementForMediaPlayback) &&
(autoplay_group_name.empty() || autoplay_group_name != "Enabled");
- prefs.autoplay_muted_videos_enabled =
- base::FeatureList::IsEnabled(features::kAutoplayMutedVideos);
-
prefs.progress_bar_completion = GetProgressBarCompletionPolicy();
prefs.use_solid_color_scrollbars = true;
#endif
+ prefs.autoplay_muted_videos_enabled =
+ base::FeatureList::IsEnabled(features::kAutoplayMutedVideos);
+#if !defined(OS_ANDROID)
+ prefs.user_gesture_required_for_media_playback_in_cross_origin_iframes =
+ base::FeatureList::IsEnabled(
+ features::kUserGestureRequiredForMediaPlaybackInCrossOriginIframes);
+#endif
+
// Handle autoplay gesture override experiment.
// Note that anything but a well-formed string turns the experiment off.
prefs.autoplay_experiment_mode = base::FieldTrialList::FindFullName(

Powered by Google App Engine
This is Rietveld 408576698