Adding an experimental flag to block autoplay with sound in cross-origin iframes

Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Currently, the default behavior is unchanged, and a follow-up CL
will collect metrics pretending the flag is on.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJoleitl572DGGESs/edit?usp=sharing

BUG=665456
Committed: https://crrev.com/df72ed087b3083bdea9b882bf473f8a9f4dc1276
Cr-Commit-Position: refs/heads/master@{#437254}

[Zhiqiang Zhang (Slow), 2016-11-10 17:39:29]

Description was changed from

==========
block autoplay with sound in cross-origin iframes

BUG=<WIP>
==========

to

==========
Block autoplay with sound in cross-origin iframes

BUG=<WIP>
==========

[Zhiqiang Zhang (Slow), 2016-11-15 15:55:36]

Description was changed from

==========
Block autoplay with sound in cross-origin iframes

BUG=<WIP>
==========

to

==========
Block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop.

BUG=665456
==========

[Zhiqiang Zhang (Slow), 2016-11-15 16:16:06]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2016-11-15 16:16:07]

Just send to you for an initial look. I feel that having
"MediaPlaybackRequiresUserGesture" for Android and having
"MediaPlaybackInCrossOriginIframesRequiresUserGesture" for desktop is very
annoying, not only because of the super long name, but also it's not very clean.

I'm thinking about merging the two flags into a String preference in Blink, and
have separate about:flags on Android and desktop. WDYT?

[Zhiqiang Zhang (Slow), 2016-11-15 16:20:54]

On 2016/11/15 16:16:07, Zhiqiang Zhang wrote:
> I'm thinking about merging the two flags into a String preference in Blink,
and
> have separate about:flags on Android and desktop. WDYT?

Or possibly we could use the same about:flag on Desktop and Android.

[Zhiqiang Zhang (Slow), 2016-11-16 11:23:23]

On 2016/11/15 16:20:54, Zhiqiang Zhang wrote:
> On 2016/11/15 16:16:07, Zhiqiang Zhang wrote:
> > I'm thinking about merging the two flags into a String preference in Blink,
> and
> > have separate about:flags on Android and desktop. WDYT?
> 
> Or possibly we could use the same about:flag on Desktop and Android.

Hmm, still not clean after I tried this :-/

Maybe we should have an "AutoplayMode" flag having options "all" and
"cross-origin".

[whywhat, 2016-11-16 17:37:16]

avayvod@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2016-11-16 17:37:17]

https://codereview.chromium.org/2496593002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2496593002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:479:
(document.settings() && isCrossOrigin(document) &&
is it this that you don't like? you could've had a helper function that takes a
document and returns true if it requires user gesture for 

bool HTMLMediaElement::documentRequiresUserGesture(const Document& document) {
  // might be a good time to remove this? :)
  if (m_autoplayHelper->isExperimentEnabled()) return true;

  if (!document.settings()) return false;

  return document.settings()->mediaPlaybackRequiresUserGesture() ||
      (document.settings()->mediaPlaybackinCORequiresUserGesture() &&
isCrossOrigin(document));
}

[Zhiqiang Zhang (Slow), 2016-11-16 18:11:41]

https://codereview.chromium.org/2496593002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2496593002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:479:
(document.settings() && isCrossOrigin(document) &&
On 2016/11/16 17:37:17, whywhat wrote:
> is it this that you don't like? you could've had a helper function that takes
a
> document and returns true if it requires user gesture for 
> 
> bool HTMLMediaElement::documentRequiresUserGesture(const Document& document) {
>   // might be a good time to remove this? :)
>   if (m_autoplayHelper->isExperimentEnabled()) return true;
> 
>   if (!document.settings()) return false;
> 
>   return document.settings()->mediaPlaybackRequiresUserGesture() ||
>       (document.settings()->mediaPlaybackinCORequiresUserGesture() &&
> isCrossOrigin(document));
> }

Already merged them into a helper function in my local patch :)

I'm more concerned about the plumbing, i.e. plumbing another boolean flag from
chrome://flags to WebKit Settings. It lacks some flexibility in case if we have
more variations for autoplay. Also, currently we are having
"MediaPlaybackRequiresUserGesture" and
"MediaPlaybackInCrossOriginIframesRequiresUserGesture" side-by-side in Blink
neglect of which platform we are on, while they do not co-exist in content/
because of the #ifdef macros. This would bring some confusion.

So what I'm thinking is to make "MediaPlaybackRequiresUserGesture" available to
all platforms, and have an optional string flag indicating the autoplay
variations. WDYT?

[Zhiqiang Zhang (Slow), 2016-11-17 16:59:34]

Patchset #2 (id:20001) has been deleted

[Zhiqiang Zhang (Slow), 2016-11-17 17:07:36]

Patchset #2 (id:40001) has been deleted

[Zhiqiang Zhang (Slow), 2016-11-17 17:41:49]

PTAL

I've made several attempts and found the current situation is quite annoying -
the flag interferes with AutoplayExperiment (we need to deprecate it) and
VoiceSearchTabHelper, which makes the logic complex.

After these attempts I think merging them into one string flag is the most
comfortable solution.

[Zhiqiang Zhang (Slow), 2016-11-17 22:01:20]

PTAL

Sorry I switched between different solutions back and forth.
Mounir is right, we should have a separate boolean flag for the experimental
feature. Reusing the flag will bring many side-effects.

BTW, I found the kDisabledGestureRequirementForMediaPlayback flag seems wrong on
desktop. Will file a bug for it.

[mlamouri (slow - plz ping), 2016-11-18 14:33:10]

l2tm but this is missing tests :)

https://codereview.chromium.org/2496593002/diff/80001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2496593002/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:5862: +              Gesture requirement for
media playback in cross-origin iframes
What about "Media playback requires user gesture in cross-origin iframes."?

https://codereview.chromium.org/2496593002/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:5865: +              User gesture requirement
for playing media elements in cross-origin iframes. Disabling this will allow
autoplay in cross-origin iframes to work.
Same as above for the first sentence so it's active instead of passive.

https://codereview.chromium.org/2496593002/diff/80001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2496593002/diff/80001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1125:
{"gesture-requirement-for-cross-origin-media-playback",
You use "cross-origin-media-playback-requires-user-gesture" for the name in the
code. What about the same name for the flag? :)

https://codereview.chromium.org/2496593002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/2496593002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:508: // initialized as
true.
The comment isn't entirely true because otherwise you could have a
`resetLockedPendingUserGesture()`. Instead, it's whether the document settings
would require media playback to have a user gesture.

Can you add a TODO to move this to the anonymous namespace when
AutoplayExperiment is removed?

[Zhiqiang Zhang (Slow), 2016-11-18 22:49:04]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 22:49:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 00:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 00:05:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhiqiang Zhang (Slow), 2016-11-21 14:55:20]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 14:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 17:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 17:11:00]

Dry run: This issue passed the CQ dry run.

[Zhiqiang Zhang (Slow), 2016-11-21 18:06:23]

PTAL

https://codereview.chromium.org/2496593002/diff/80001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2496593002/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:5862: +              Gesture requirement for
media playback in cross-origin iframes
On 2016/11/18 14:33:10, mlamouri (OOO until 29-11) wrote:
> What about "Media playback requires user gesture in cross-origin iframes."?

Done.

https://codereview.chromium.org/2496593002/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:5865: +              User gesture requirement
for playing media elements in cross-origin iframes. Disabling this will allow
autoplay in cross-origin iframes to work.
On 2016/11/18 14:33:10, mlamouri (OOO until 29-11) wrote:
> Same as above for the first sentence so it's active instead of passive.

Done.

https://codereview.chromium.org/2496593002/diff/80001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2496593002/diff/80001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1125:
{"gesture-requirement-for-cross-origin-media-playback",
On 2016/11/18 14:33:10, mlamouri (OOO until 29-11) wrote:
> You use "cross-origin-media-playback-requires-user-gesture" for the name in
the
> code. What about the same name for the flag? :)

Done.

https://codereview.chromium.org/2496593002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/2496593002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.h:508: // initialized as
true.
On 2016/11/18 14:33:10, mlamouri (OOO until 29-11) wrote:
> The comment isn't entirely true because otherwise you could have a
> `resetLockedPendingUserGesture()`. Instead, it's whether the document settings
> would require media playback to have a user gesture.
> 
> Can you add a TODO to move this to the anonymous namespace when
> AutoplayExperiment is removed?

Done.

[whywhat, 2016-11-21 18:54:15]

lgtm

Seems like Mounir already tried to lgtm with l2tm (or is it a new way of saying
lgtm without making it count?) so stampity stamp.

[Zhiqiang Zhang (Slow), 2016-11-21 20:39:22]

On 2016/11/21 18:54:15, whywhat wrote:
> lgtm
> 
> Seems like Mounir already tried to lgtm with l2tm (or is it a new way of
saying
> lgtm without making it count?) so stampity stamp.

Thanks:)

I'll land this later since there are some pending discussions about the overall
project.

[Zhiqiang Zhang (Slow), 2016-11-29 16:04:44]

Description was changed from

==========
Block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop.

BUG=665456
==========

to

==========
Block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

BUG=665456
==========

[Zhiqiang Zhang (Slow), 2016-11-29 16:09:41]

Description was changed from

==========
Block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

BUG=665456
==========

to

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

BUG=665456
==========

[Zhiqiang Zhang (Slow), 2016-11-29 16:11:24]

zqzhang@chromium.org changed reviewers:
+ foolip@chromium.org, isherman@chromium.org, palmer@chromium.org,
pfeldman@chromium.org

[Zhiqiang Zhang (Slow), 2016-11-29 16:11:25]

+foolip: WebKit/ (we are aware that sites (esp. ads) will be broken if the flag
is enabled but we are working on several solutions)
+pfeldman: content/
+isherman: histograms.xml
+palmer: common_param_traits_macros.h

[pfeldman, 2016-11-29 19:24:16]

Could you point to intent to implement?

[Zhiqiang Zhang (Slow), 2016-11-29 20:45:42]

Description was changed from

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

BUG=665456
==========

to

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJ...

BUG=665456
==========

[Zhiqiang Zhang (Slow), 2016-11-29 20:53:29]

On 2016/11/29 19:24:16, pfeldman wrote:
> Could you point to intent to implement?

I updated the CL description to include the design doc.

We haven't decided whether to send intent to implement yet. The reason is that
people may have many opinions on autoplay and we want to avoid make the public
thread for this feature get overwhelmed. At the current phase we are only
implementing it behind a flag and collect metrics pretending the flag is on.

We are asking out PM to decide whether we should send an intent to implement.

[Ilya Sherman, 2016-11-29 21:08:42]

histograms.xml lgtm

[palmer, 2016-11-30 01:38:19]

lgtm

[mlamouri (slow - plz ping), 2016-11-30 10:14:43]

lgtm

[foolip, 2016-11-30 10:16:51]

rs lgtm

[Zhiqiang Zhang (Slow), 2016-12-05 15:30:23]

Ping! pfeldman, can you take a look?

On 2016/11/29 20:53:29, Zhiqiang Zhang wrote:
> On 2016/11/29 19:24:16, pfeldman wrote:
> > Could you point to intent to implement?
> 
> I updated the CL description to include the design doc.
> 
> We haven't decided whether to send intent to implement yet. The reason is that
> people may have many opinions on autoplay and we want to avoid make the public
> thread for this feature get overwhelmed. At the current phase we are only
> implementing it behind a flag and collect metrics pretending the flag is on.
> 
> We are asking out PM to decide whether we should send an intent to implement.

So currently we prefer to delay the intent to implement until we have a clear
plan, so as to avoid distraction from public parties. For the current phase, we
are only collecting metrics without changing the default behavior.

[pfeldman, 2016-12-06 19:58:32]

lgtm

[dglazkov, 2016-12-06 20:12:41]

On 2016/11/29 at 20:53:29, zqzhang wrote:
> On 2016/11/29 19:24:16, pfeldman wrote:
> > Could you point to intent to implement?
> 
> I updated the CL description to include the design doc.
> 
> We haven't decided whether to send intent to implement yet. The reason is that
people may have many opinions on autoplay and we want to avoid make the public
thread for this feature get overwhelmed. At the current phase we are only
implementing it behind a flag and collect metrics pretending the flag is on.
> 
> We are asking out PM to decide whether we should send an intent to implement.

zqzhang, please make sure that you send the I2I.

[Zhiqiang Zhang (Slow), 2016-12-06 21:25:30]

On 2016/12/06 20:12:41, dglazkov wrote:
> On 2016/11/29 at 20:53:29, zqzhang wrote:
> > On 2016/11/29 19:24:16, pfeldman wrote:
> > > Could you point to intent to implement?
> > 
> > I updated the CL description to include the design doc.
> > 
> > We haven't decided whether to send intent to implement yet. The reason is
that
> people may have many opinions on autoplay and we want to avoid make the public
> thread for this feature get overwhelmed. At the current phase we are only
> implementing it behind a flag and collect metrics pretending the flag is on.
> > 
> > We are asking out PM to decide whether we should send an intent to
implement.
> 
> zqzhang, please make sure that you send the I2I.

Thanks, will do.

[Zhiqiang Zhang (Slow), 2016-12-08 12:04:24]

Description was changed from

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJ...

BUG=665456
==========

to

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Currently, the default behavior is unchanged, and a follow-up CL
will collect metrics pretending the flag is on.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJ...

BUG=665456
==========

[Zhiqiang Zhang (Slow), 2016-12-08 13:16:50]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 13:17:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 14:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 14:36:49]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Zhiqiang Zhang (Slow), 2016-12-08 15:29:05]

On 2016/12/06 21:25:30, Zhiqiang Zhang wrote:
> On 2016/12/06 20:12:41, dglazkov wrote:
> > On 2016/11/29 at 20:53:29, zqzhang wrote:
> > > On 2016/11/29 19:24:16, pfeldman wrote:
> > > > Could you point to intent to implement?
> > > 
> > > I updated the CL description to include the design doc.
> > > 
> > > We haven't decided whether to send intent to implement yet. The reason is
> that
> > people may have many opinions on autoplay and we want to avoid make the
public
> > thread for this feature get overwhelmed. At the current phase we are only
> > implementing it behind a flag and collect metrics pretending the flag is on.
> > > 
> > > We are asking out PM to decide whether we should send an intent to
> implement.
> > 
> > zqzhang, please make sure that you send the I2I.
> 
> Thanks, will do.

I'm landing this now. As discussed over email, the I2I is on its way :)

[Zhiqiang Zhang (Slow), 2016-12-08 15:29:18]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-12-08 15:29:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
avayvod@chromium.org, mlamouri@chromium.org, foolip@chromium.org,
palmer@chromium.org, isherman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2496593002/#ps180001
(title: "nits")

[commit-bot: I haz the power, 2016-12-08 15:29:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 16:08:00]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1481210958450880,
"parent_rev": "c5cc38badd61e6bada031b2aaebcadd25f3f0882", "commit_rev":
"a9cfb06fda2e8bc7696ea1adc84d023b84bc8088"}

[commit-bot: I haz the power, 2016-12-08 16:08:29]

Description was changed from

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Currently, the default behavior is unchanged, and a follow-up CL
will collect metrics pretending the flag is on.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJ...

BUG=665456
==========

to

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Currently, the default behavior is unchanged, and a follow-up CL
will collect metrics pretending the flag is on.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJ...

BUG=665456
==========

[commit-bot: I haz the power, 2016-12-08 16:08:31]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2016-12-08 16:10:29]

Description was changed from

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Currently, the default behavior is unchanged, and a follow-up CL
will collect metrics pretending the flag is on.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJ...

BUG=665456
==========

to

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Currently, the default behavior is unchanged, and a follow-up CL
will collect metrics pretending the flag is on.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJ...

BUG=665456

Committed: https://crrev.com/df72ed087b3083bdea9b882bf473f8a9f4dc1276
Cr-Commit-Position: refs/heads/master@{#437254}
==========

[commit-bot: I haz the power, 2016-12-08 16:10:31]

Patchset 8 (id:??) landed as
https://crrev.com/df72ed087b3083bdea9b882bf473f8a9f4dc1276
Cr-Commit-Position: refs/heads/master@{#437254}

[Charlie Reis, 2016-12-08 19:30:07]

On 2016/12/08 16:10:31, commit-bot: I haz the power wrote:
> Patchset 8 (id:??) landed as
> https://crrev.com/df72ed087b3083bdea9b882bf473f8a9f4dc1276
> Cr-Commit-Position: refs/heads/master@{#437254}

Note: A new test from this CL is failing on the Site Isolation Linux FYI bot. 
Please see https://crbug.com/672570.

[Charlie Reis, 2016-12-08 19:30:31]

Description was changed from

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Currently, the default behavior is unchanged, and a follow-up CL
will collect metrics pretending the flag is on.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJ...

BUG=665456

Committed: https://crrev.com/df72ed087b3083bdea9b882bf473f8a9f4dc1276
Cr-Commit-Position: refs/heads/master@{#437254}
==========

to

==========
Adding an experimental flag to block autoplay with sound in cross-origin iframes

This CL adds an experimental flag to block autoplay with sound in
cross-origin iframes on Desktop. The experimental flag is
disabled by default, and will override
the "MediaPlaybaRequiresUserGesture" flag.

Currently, the default behavior is unchanged, and a follow-up CL
will collect metrics pretending the flag is on.

Design doc:
https://docs.google.com/a/google.com/document/d/1g05pahL0py0TSWIDwli1MLJiRuuJ...

BUG=665456

Committed: https://crrev.com/df72ed087b3083bdea9b882bf473f8a9f4dc1276
Cr-Commit-Position: refs/heads/master@{#437254}
==========