chrome/app/generated_resources.grd - Issue 2496593002: Adding an experimental flag to block autoplay with sound in cross-origin iframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 2496593002: Adding an experimental flag to block autoplay with sound in cross-origin iframes (Closed)

Patch Set: falling back to adding a boolean flag Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 431e3ffa972a14b1294dda96fb2ad731c37229dc..9c809b946980bfb692b3b1fc48aeb61247c5c4a3 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -5857,6 +5857,14 @@ Keep your key file in a safe place. You will need it to create new versions of y

User gesture requirement for playing media elements. Disabling this will allow autoplay to work.

</message>

+ <if expr="not is_android">

+ <message name="IDS_FLAGS_CROSS_ORIGIN_MEDIA_PLAYBACK_REQUIRES_USER_GESTURE_NAME" desc="Title for the flag for gesture requiment for media playback">

+ Gesture requirement for media playback in cross-origin iframes

mlamouri (slow - plz ping) 2016/11/18 14:33:10 What about "Media playback requires user gesture i

Zhiqiang Zhang (Slow) 2016/11/21 18:06:23 Done.

+ </message>

+ <message name="IDS_FLAGS_CROSS_ORIGIN_MEDIA_PLAYBACK_REQUIRES_USER_GESTURE_DESCRIPTION" desc="Description for the flag for gesture requiment for media playback">

+ User gesture requirement for playing media elements in cross-origin iframes. Disabling this will allow autoplay in cross-origin iframes to work.

mlamouri (slow - plz ping) 2016/11/18 14:33:10 Same as above for the first sentence so it's activ

Zhiqiang Zhang (Slow) 2016/11/21 18:06:23 Done.

+ </message>

+ </if>

Forces touchstart, and touchmove event listeners on document level targets (which haven't requested otherwise) to be treated as passive.

</message>

« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/about_flags.cc » ('J')